Repository navigation
Conversation
4 tasks done
Only Stage 3 checks estimates against accuracy targets, so the AccuracyModel trait (local_guarantee, satisfies) and DefaultAccuracyModel move to asap-plan-selection. logical-optimizer keeps the analytical estimators and exposes local_guarantee, sketch_guarantee and satisfies; DefaultAccuracyModel delegates to them (Q53). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zzylol
force-pushed
the
stack/cleanup-9-delete-legacy-search
branch
from
October 5, 2026 06:21
f9fc726 to
a7a07d8
Compare
zzylol
force-pushed
the
stack/cleanup-10-accuracy-model-to-plan-selection
branch
from
October 5, 2026 06:21
6d28dba to
910df58
Compare
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack: #574 → #620 → #618 → #621 → #627 → #625 → #628 → #632 → #634 → #616 → #617 → #622 → #624 → #629 → #630 → #631 → #633 → #635 → #636 → #637
Problem
Q53: only Stage 3 checks an estimate against its accuracy target, but the
AccuracyModeltrait andDefaultAccuracyModellived in Stage 1's crate. The legacy search was the reason; #635 deleted it.Changes
asap_plan_selection::accuracymodule, re-exported at the crate root:AccuracyModelwithlocal_guaranteeandsatisfies.DefaultAccuracyModel, which delegates to logical-optimizer's estimators.PlanningModelsnow takes this trait. As before, Stage 3 rejects an estimate whose family has no model (local_guaranteereturnsNone).asap_logical_optimizer::accuracyno longer defines a model. It exposes the analytical functions the default delegates to:local_guaranteeandsketch_guarantee(madepub)satisfies, the conservative target check moved out ofDefaultAccuracyModel::satisfiesunchangedAccuracyModel/DefaultAccuracyModel.propagateandexact_operation_rulewere already dropped in chore: delete the legacy replacement search and CostModel #635 (they depended on deleted modules).asap_plan_selection::{AccuracyModel, DefaultAccuracyModel}:planner/tests/summary_sharing.rs(UnivMonEvidence) andfrontend-promql/tests/univmon_candidates.rs.stage_pipelinedevtool needs no change: it reports the model by name ("DefaultAccuracyModel").PlanningModels, so it needs no change either.Rebase note: rebased onto #627: the plan-selection
AccuracyModelkeepsanswers(statistic, guarantee)next tosatisfies, as a default method delegating to the newasap_logical_optimizer::accuracy::answers, andDefaultAccuracyModeldelegates it like the other two methods; Stage 3 still callsmodels.accuracy.answers(...). #621's UnivMon L2 tests now calllocal_guarantee/satisfiesdirectly.Stacked on #635.
Test plan
cargo fmt --all --checkcargo clippy --workspace --all-targets --all-features --locked -- -D warningscargo test --workspace --locked: 1280 passed, 0 failed, 14 ignored (after the rebase on main d4869a7; was 1256 passed, 22 ignored)🤖 Generated with Claude Code