Conversation
3 tasks done
zzylol
force-pushed
the
stack/cleanup-5-port-selection-tests
branch
from
October 5, 2026 03:07
67ba774 to
d5313d6
Compare
zzylol
force-pushed
the
stack/cleanup-6-delete-candidate-selection
branch
from
October 5, 2026 03:07
bdb713a to
7cc8150
Compare
This was referenced Oct 5, 2026
Nothing in the stage pipeline used global_selection, cost_sorted or recurrence_profiles once the tests that only needed a selected DAG moved to plan_stages. The legacy-only test files and the recurrence tests built on it go with it; the behaviours only they covered are listed in #623. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zzylol
force-pushed
the
stack/cleanup-6-delete-candidate-selection
branch
from
October 5, 2026 06:21
7cc8150 to
66f8a3f
Compare
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack: #574 → #620 → #618 → #621 → #627 → #625 → #628 → #632 → #634 → #616 → #617 → #622 → #624 → #629 → #630 → #631 → #633 → #635 → #636 → #637
Problem
After the ports in #629, nothing in the stage pipeline, facade or devtools uses the legacy selection (
asap_plan_selection::candidate_selection:global_selection,cost_sorted,recurrence_profiles). Only tests of that selection itself still did (Q52).Changes
crates/plan-selection/src/candidate_selection.rsand itslib.rsmodule, doc entry and re-exports (CompositionDecision,CostedGlobalSelection,RankedTargetSubDAGCandidates,RecurrenceProfileMap).integration-tests/tests/exact_composition.rs,promql_to_post_asap.rsandsql_to_post_asap.rs. All three driveASAPStrategies/search_workloadandglobal_selectionthroughout.cost/recurrence.rs: delete the tests built onrecurrence_profiles/global_selection_with_recurrence(the "multiple roots sharing a sub-DAG" block).cost_model::validated_candidate_rankingand its three teststest_support.rsmaintained/timed/maintained_post_asap_daginasap_integration_tests::post_asap(post_asap_dagstays)crate::candidate_selection::*become plain text. The surrounding legacy prose is left for the docs step.Behaviours that only these tests covered are listed in #623: accuracy propagation and exact composition (max/avg over quantile, DDSketch ratio), CSE share-vs-recompute by recurrence and consumer count, rollup vs CSE, evidence-ranked physical cost, "missing accuracy evidence is never selected", and reconciled tighter-target propagation.
Stacked on #629.
Test plan
cargo fmt --all --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspace: 1519 passed, 0 failed, 14 ignored (after the rebase on main d4869a7; was 1516 passed, 14 ignored)🤖 Generated with Claude Code