Conversation
3 tasks done
zzylol
force-pushed
the
stack/cleanup-2-dag-export-module
branch
from
October 5, 2026 03:07
59d531f to
8d8621f
Compare
zzylol
force-pushed
the
stack/cleanup-3-legacy-cost
branch
from
October 5, 2026 03:07
7e08c9d to
281858b
Compare
This was referenced Oct 5, 2026
PhysicalPlanCostModel, PlannerPhysicalPlanProvider and PhysicalEvidenceSnapshot had no caller once dag_export was gone, and Stage 3 never used them. asap_types::cost keeps only CostUnit; the annotation and workload-summary types were dag_export's. cache_hit_ratios moves into analytical_cost's tests, its only caller. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zzylol
force-pushed
the
stack/cleanup-2-dag-export-module
branch
from
October 5, 2026 06:21
8d8621f to
c64da44
Compare
zzylol
force-pushed
the
stack/cleanup-3-legacy-cost
branch
from
October 5, 2026 06:21
281858b to
84e9cfd
Compare
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack: #574 → #620 → #618 → #621 → #627 → #625 → #628 → #632 → #634 → #616 → #617 → #622 → #624 → #629 → #630 → #631 → #633 → #635 → #636 → #637
Problem
PhysicalPlanCostModel,PlannerPhysicalPlanProviderandPhysicalEvidenceSnapshot(plan-selectioncost/physical_plan_cost_model.rs) priced plans for the legacy selection anddag_export. Withdag_exportgone (#616, #617), nothing calls them, and Stage 3 never did. Most ofasap_types::cost(cost annotations, workload cost summaries) was thedag_exportwire format.Changes
crates/plan-selection/src/cost/physical_plan_cost_model.rsand itscost/mod.rsentry.asap_types::cost: keep onlyCostUnit(still used by plan-selection'sCostModel). DeleteCostSource,BaselineRef,CostInput,CostAnnotation,benefit_ratio,total_cost,UnitMismatch,sum_workload_costs,WorkloadCostSummary,workload_cost_summaryand their tests.analytical_cost::cache_hit_ratios: delete it. Its only callers were tests. The result/buffer hit-ratio fields ofResolvedCacheProfile, which only it read, go too. The fail-closed cache tests now callresolve_cache_profiledirectly. Two tests drop their hit-ratio assertions and keep the CPU / scan-byte effect assertions.Not deleted, though no non-test code reaches them any more:
query_physical_lowering::lower_query_physical_dagand the analytical whole-DAG comparison (estimate_physical_dag_comparison), together with the storage-I/O / hand-off evidence they consume. They are the natural starting point for #615 (evidence-driven Stage 3 cost), so I left them for that issue to keep or delete.Stacked on #617.
Test plan
cargo fmt --all --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspace: 1615 passed, 0 failed, 13 ignored (after the rebase on main d4869a7; was 1612 passed, 13 ignored)🤖 Generated with Claude Code