Conversation
3 tasks done
zzylol
force-pushed
the
stack/cleanup-2-dag-export-module
branch
from
October 5, 2026 03:07
59d531f to
8d8621f
Compare
zzylol
force-pushed
the
stack/cleanup-1-dag-export-bin
branch
from
October 5, 2026 03:07
1223aa3 to
4af8f07
Compare
This was referenced Oct 5, 2026
Nothing outside tests and comments used it once the dag_export bin was gone; the viewer reads stage_pipeline documents. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zzylol
force-pushed
the
stack/cleanup-1-dag-export-bin
branch
from
October 5, 2026 06:21
4af8f07 to
e134bfd
Compare
zzylol
force-pushed
the
stack/cleanup-2-dag-export-module
branch
from
October 5, 2026 06:21
8d8621f to
c64da44
Compare
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack: #574 → #620 → #618 → #621 → #627 → #625 → #628 → #632 → #634 → #616 → #617 → #622 → #624 → #629 → #630 → #631 → #633 → #635 → #636 → #637
Problem
With the
dag_exportbin gone (#616), nothing outside a few tests and comments usedasap_types::dag_export. The viewer readsstage_pipelinedocuments instead.Changes
crates/types/src/dag_export.rsand itslib.rsmodule.logical-optimizerpass1/explanation.rs: thenode_hash_matches_dag_export_hash_for_the_same_sub_dagtest, plus doc comments that pointed atdag_export.pass1/replacement.rs: theexport_summaryassertion now checks the candidate node's own guarantee, which is what the exported field held.integration-tests/tests/exact_composition.rs: thedag_export_carries_explicit_stage_and_plain_schema_for_a_composed_plantest.types/src/cost.rs,ir/properties/guarantee.rs,types/Cargo.toml,tools/dag-viewer/node-style.js,crates/devtools/tests/viewer_contract.rs, and.github/workflows/rust.yml. The viewer kind contract is checked by the devtoolsviewer_contracttest, not by the types tests.Stacked on #616.
Test plan
cargo fmt --all --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspace: 1646 passed, 0 failed, 13 ignored (after the rebase on main d4869a7; was 1643 passed, 13 ignored)🤖 Generated with Claude Code