Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unused classes survive the early tree shaker and are processed by compile-time passes, generic specialization, and Jass class lowering. Remove classes whose types, surviving implementations, fields, and inheritance relationships are unreachable, collecting dependencies during the existing function walk rather than traversing function bodies again.
Keep the class universe when reachable reflection or explicit type-ID reads expose its numbering, including reads consumed at compile time. Preserve compile-time allocator state, Jass inheritance joins that share an allocator, and Lua nominal identities for targeted specializations. Record generic static-field ownership during class translation so specialization cannot lose classes used without an instance. Remove the completed class-pruning item from the backlog.
Validation:
git diff --checkpassed. The full test suite remains for PR CI.