Repository navigation
Reuse the final garbage removal's Jass call relations - #1458
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jass emission recalculates the whole-program call relation immediately after the final garbage-removal pass, which already leaves that analysis current. Reuse the existing graph: no pass modifies the program between the removal and emission. This removes one whole-program traversal without adding a new cache or invalidation protocol.
Add a regression that fails on the duplicate calculation and checks graph reuse with callbacks, an externally preserved entry point, and unreachable functions, both with and without optimization. Remove the completed backlog item and record the class-aware dispatch reachability proposal discussed during the follow-up.
Validation: 191 tests in OptimizerTests, DeterministicChecks, and HotReloadPipelineTests passed with no skips;
git diff --checkpassed. Existing tests cover emitted Jass/Lua behavior and compilation-order determinism. The new graph-reuse regression failed before the change.The change removes a guaranteed redundant traversal; no end-to-end build-time speedup is claimed. The separate class-pruning PR is #1457 and is not a dependency.