Repository navigation
Fix WWW::Mediawiki::Client sprintf and CR handling - #1691
Merged
Merged
Conversation
Support larger safe sprintf widths and retain bare carriage returns in quote-like source constructs. Add regressions for both behaviors. Generated with [Codex](https://openai.com/codex) Co-Authored-By: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sprintffield width limit to 1,000,000 while keeping numeric precision capped at 8192.Fixes #1692.
Validation
nice -n 19 makepassed.nice -n 19 make check-linkspassed.jcpan -t WWW::Mediawiki::Client: distribution test summary is 118/118 passing;t/server.tis skipped because no local MediaWiki server is configured. The command then exited 8 during dependency follow-up.re/anyof.t(baseline 1187/1187, current 1186/1187). The branch base commitcf9eb1681reproduces the sameNANYOFM[:]diagnostic for(?i:[^:]), and the Joni debug description test at that base expects this output, so the mismatch predates this PR.