dont show unauthorized notification on the login page

[sudo87]

Description

This PR intends to fix #11721

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 19.91%. Comparing base (ed1db53) to head (0187446).

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #14054      +/-   ##
============================================
- Coverage     19.91%   19.91%   -0.01%     
+ Complexity    20200    20196       -4     
============================================
  Files          6373     6373              
  Lines        577230   577234       +4     
  Branches      70696    70696              
============================================
- Hits         114958   114953       -5     
- Misses       449703   449715      +12     
+ Partials      12569    12566       -3     

Flag	Coverage Δ
uitests	3.70% <ø> (-0.01%)	⬇️
unittests	21.18% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sudo87]

@blueorangutan ui

[blueorangutan]

@sudo87 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/14054 (QA-JID-986)

[shwstppr]

ui-login-notification.mp4

Looks good.
While it now shows the session notification once if you've a previously expired session, it doesn't show it every time like earlier

[Copilot]

🟡 Changes recommended

The new requestCommand extraction misses the common POST case where config.data is a URLSearchParams instance, so allowlisted commands (e.g., forgotPassword) may still trigger the 401 flow unexpectedly.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Fixes an unwanted “Unauthorized / session expired” notification being displayed on the login page by refining the UI’s global 401-response handling in the Axios error interceptor.

Changes:

• Suppresses the generic 401 “unauthorized” notification when the current route is /user/login.
• Attempts to better detect the failed API command for 401 responses (including parsing form-encoded POST bodies) so specific commands can bypass the global 401 flow.
• Moves countNotify increment/commit to only occur when a notification is actually shown for 401 cases.

File summaries

File	Description
ui/src/utils/request.js	Refines global 401 handling to avoid showing the unauthorized notification on the login page and improves command detection for 401 exceptions.

Review details

• Files reviewed: 1/1 changed files
• Comments generated: 1
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[sudo87]

thank you @shwstppr for testing the changes.

[Copilot]

🔵 Needs a closer look

The unauthenticated listOauthProvider request is not covered by the notification suppression logic.

0 open findings

1 resolved since last review

• requestCommand is not extracted for the common POST case where axios is called with `data:…

🧠 Review effort: Lite

---

Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

[harikrishna-patnala]

code LGTM