Skip to content

show a session expired warning when the session runs out - #14369

Open
Damans227 wants to merge 1 commit into
apache:mainfrom
Damans227:fro-6451-session-expired
Open

Damans227 wants to merge 1 commit into
apache:mainfrom
Damans227:fro-6451-session-expired

Conversation

@Damans227

@Damans227 Damans227 commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

When your session runs out on any page, the UI shows a red "Unauthorized" popup that says "Session expired, authorization verification failed." and stays until you close it. It reads like something broke, when all that happened is the login timed out. This changes it to an orange "Session Expired" warning that says "Your session has expired. Please sign in again to continue." and goes away by itself. #14054 already stopped the popup on the login page itself, this covers the real timeout.

Test:

Log in, let the session run out, then click anything.

Before:

before

After:

after

New unit test:

PASS tests/unit/utils/request.spec.js
  ✓ shows a session expired warning when the session times out
  ✓ shows nothing when already on the login page

@codecov

codecov Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 19.91%. Comparing base (17294ca) to head (819dbb8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #14369   +/-   ##
=========================================
  Coverage     19.91%   19.91%           
+ Complexity    20198    20196    -2     
=========================================
  Files          6373     6373           
  Lines        577234   577234           
  Branches      70696    70696           
=========================================
+ Hits         114945   114974   +29     
+ Misses       449724   449696   -28     
+ Partials      12565    12564    -1     
Flag Coverage Δ
uitests 3.79% <ø> (+0.08%) ⬆️
unittests 21.18% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19482

@Damans227
Damans227 marked this pull request as ready for review October 8, 2026 19:21
@sudo87

sudo87 commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@sudo87 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/14369 (QA-JID-1001)

@sudo87 sudo87 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, verified it

Screen.Recording.2026-10-09.at.12.39.47.PM.mov

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants