Skip to content

docs(runbooks): defer to the pull-request closing rule (#708) - #709

Merged
ss-o merged 1 commit into
mainfrom
docs/tracker-closing-rule
Sep 29, 2026
Merged

ss-o merged 1 commit into
mainfrom
docs/tracker-closing-rule

Conversation

@ss-o

@ss-o ss-o commented Sep 29, 2026

Copy link
Copy Markdown
Member

Summary

  • runbooks/project-tracker.md said to "Link implementation pull requests with a closing keyword", unconditionally. runbooks/pull-requests.md (following ADR-0022) allows Closes #N only when the diff meets every acceptance criterion and asks for Refs #N otherwise. The tracker runbook now points to that rule instead of contradicting it.
  • One sentence changes; nothing else in the runbook does.
  • Left alone on purpose: runbooks/sub-issues.md asks for a closing keyword from an implementation pull request to its own sub-issue, which that pull request completes, so it agrees with the pull-request rule.

Closes #708

Instruction impact review

  1. Kind: canonical-detail runbook prose. The owning rule is in runbooks/pull-requests.md (ADR-0022), unchanged.
  2. Consumers: agents and humans using the tracker runbook; routed for project-tracking, and referenced by the thin project-tracker skill. org_policy_report.py impact lists 15 repositories as shared-policy review candidates; none carries a copy of this sentence (checked in every child checkout).
  3. Canonical owner: unchanged; the tracker runbook now defers to it.
  4. Duplication or contradiction: removes one contradiction; no new copy of the rule.
  5. Manifest routes: none change.
  6. Mandatory rule delivery: the rule lives in the pull-request runbook and ADR-0022, independent of this runbook.
  7. Generated output and size limits: scripts/validate-agent-policy.py passes.

Verification

  • python3 scripts/validate-agent-policy.py: passed.
  • python3 -m unittest scripts/test_validate_agent_policy.py: OK.
  • python3 scripts/org-routing.py validate: inventory valid.
  • python3 scripts/org_policy_report.py impact --changed runbooks/project-tracker.md: shared-policy review, 15 candidates, no copies found.

Agent handoff

The tracker runbook told readers to link implementation pull requests with a closing keyword unconditionally, which contradicts the pull-request runbook and ADR-0022: Closes only when every acceptance criterion is met, Refs otherwise. It now points to that rule.
@ss-o ss-o added type:docs Documentation-only work. area:meta Organization-wide policy, templates, or meta-repo work. labels Sep 29, 2026
@ss-o
ss-o requested a review from a team as a code owner September 29, 2026 15:22
@ss-o

ss-o commented Sep 29, 2026

Copy link
Copy Markdown
Member Author

Copilot review request on 0ca6f21 did not register.

This pull request is blocked on a review of record until the maintainer waits for Copilot or elects the ADR-0026 fallback.

@ss-o ss-o left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fallback review under ADR-0026: Copilot request not registered on 0ca6f21

The maintainer elected the fallback after the Copilot request on this head did not register (recorded in the comment above). Executed under .github/skills/code-review/SKILL.md against .github/instructions/code-review-generic.instructions.md.

Findings

No actionable findings.

Note

This is a maintainer-elected self-review by the author's session, not an independent review or approval to merge.

Scope: the one-file diff of #709 at 0ca6f21 against main at eeb1646, and the acceptance criteria of #708.

Validation

  • Passed: 11 hosted checks on this head, including Validate Agent Instructions and links-check. Locally: validate-agent-policy.py, the policy tests, org-routing.py validate, and org_policy_report.py impact (15 review candidates, none carries a copy of the sentence).
  • Skipped or unavailable: none relevant.
Checklist verdicts and supporting evidence
  • Accuracy against the canonical owner: pass. The new sentence matches runbooks/pull-requests.md section 2 (Closes #N only when the diff meets every acceptance criterion, Refs #N otherwise), which follows ADR-0022 (#708 criterion 1).
  • Consistency: pass. runbooks/sub-issues.md asks for a closing keyword from a pull request to its own sub-issue, which that pull request completes; it agrees with the rule and needs no change.
  • Links: pass. [pull-requests.md](pull-requests.md) resolves from runbooks/; links-check passed.
  • Routing and policy: pass. No manifest route changes; scripts/validate-agent-policy.py passes (#708 criterion 2).
  • Security and CI compliance: not applicable. Prose only.

Limits and follow-up

  • None. Merging is the maintainer's decision; the maintainer has authorized it for this head. #668 stays open; this pull request refs it.

@ss-o
ss-o merged commit 3408c58 into main Sep 29, 2026
11 checks passed
@ss-o
ss-o deleted the docs/tracker-closing-rule branch September 29, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:meta Organization-wide policy, templates, or meta-repo work. type:docs Documentation-only work.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

docs(runbooks): use the pull-request closing rule in the tracker runbook

1 participant