docs(runbooks): defer to the pull-request closing rule (#708) - #709
Conversation
The tracker runbook told readers to link implementation pull requests with a closing keyword unconditionally, which contradicts the pull-request runbook and ADR-0022: Closes only when every acceptance criterion is met, Refs otherwise. It now points to that rule.
|
Copilot review request on 0ca6f21 did not register.
This pull request is blocked on a review of record until the maintainer waits for Copilot or elects the ADR-0026 fallback. |
ss-o
left a comment
There was a problem hiding this comment.
Fallback review under ADR-0026: Copilot request not registered on 0ca6f21
The maintainer elected the fallback after the Copilot request on this head did not register (recorded in the comment above). Executed under .github/skills/code-review/SKILL.md against .github/instructions/code-review-generic.instructions.md.
Findings
No actionable findings.
Note
This is a maintainer-elected self-review by the author's session, not an independent review or approval to merge.
Scope: the one-file diff of #709 at 0ca6f21 against main at eeb1646, and the acceptance criteria of #708.
Validation
- Passed: 11 hosted checks on this head, including
Validate Agent Instructionsandlinks-check. Locally:validate-agent-policy.py, the policy tests,org-routing.py validate, andorg_policy_report.py impact(15 review candidates, none carries a copy of the sentence). - Skipped or unavailable: none relevant.
Checklist verdicts and supporting evidence
- Accuracy against the canonical owner: pass. The new sentence matches
runbooks/pull-requests.mdsection 2 (Closes #Nonly when the diff meets every acceptance criterion,Refs #Notherwise), which follows ADR-0022 (#708 criterion 1). - Consistency: pass.
runbooks/sub-issues.mdasks for a closing keyword from a pull request to its own sub-issue, which that pull request completes; it agrees with the rule and needs no change. - Links: pass.
[pull-requests.md](pull-requests.md)resolves fromrunbooks/;links-checkpassed. - Routing and policy: pass. No manifest route changes;
scripts/validate-agent-policy.pypasses (#708 criterion 2). - Security and CI compliance: not applicable. Prose only.
Limits and follow-up
- None. Merging is the maintainer's decision; the maintainer has authorized it for this head. #668 stays open; this pull request refs it.
Summary
runbooks/project-tracker.mdsaid to "Link implementation pull requests with a closing keyword", unconditionally.runbooks/pull-requests.md(following ADR-0022) allowsCloses #Nonly when the diff meets every acceptance criterion and asks forRefs #Notherwise. The tracker runbook now points to that rule instead of contradicting it.runbooks/sub-issues.mdasks for a closing keyword from an implementation pull request to its own sub-issue, which that pull request completes, so it agrees with the pull-request rule.Closes #708
Instruction impact review
runbooks/pull-requests.md(ADR-0022), unchanged.project-tracking, and referenced by the thinproject-trackerskill.org_policy_report.py impactlists 15 repositories as shared-policy review candidates; none carries a copy of this sentence (checked in every child checkout).scripts/validate-agent-policy.pypasses.Verification
python3 scripts/validate-agent-policy.py: passed.python3 -m unittest scripts/test_validate_agent_policy.py: OK.python3 scripts/org-routing.py validate: inventory valid.python3 scripts/org_policy_report.py impact --changed runbooks/project-tracker.md: shared-policy review, 15 candidates, no copies found.Agent handoff