Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated Windows installer currently extracts downloaded ZIPs without checking the published checksum. This change embeds each release ZIP's SHA256 in the installer during CI and verifies the downloaded bytes before extraction or copying files. A mismatch stops installation and preserves an existing installation.
The build step computes the digest from the archive, checks its release checksum file, covers architecture aliases, and fails on missing artifacts, invalid checksums, or unsupported template structure. Runtime verification uses the embedded digest, so replacing both a download and its sidecar checksum is rejected. It adds no signing service and retains cargo-dist 0.30.2.
Related to WVDSH-2364. This is an integrity improvement, not a confirmed fix for the unreproduced Defender warning. It relies on trusted delivery of the installer and cannot protect against replacement of both installer and archive.
Validation: six tests pass on Windows PowerShell 5.1 and PowerShell 7. They run the actual generated installer with harmless local archives and isolated install directories, covering valid installs, changed archives and sidecars, missing downloads, invalid build inputs, and template rejection. Existing files remain unchanged and no executable is extracted on checksum mismatch. The same suite also passes against freshly generated cargo-dist 0.30.2 and 0.33.0 installers. Actionlint, release planning, the 0.30.2 PowerShell global-artifact build, and
git diff --checkpass.release.ymlnow has a small maintained post-build step, documented indocs/windows-installer.md. The full release workflow has not been run on GitHub. This draft is independent of the Azure signing draft; when combining them, preserve checksum injection before installer signing and revalidate the merged workflow.