Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows release artifacts are currently unsigned. This draft adds Azure Artifact Signing for
wavedash.exebefore ZIP creation and for the PowerShell installer, then blocks publication unless the final artifacts have valid, timestamped signatures from the configured publisher and the ZIP matches its checksum.Related to WVDSH-2364. The reported warning was not reproduced with CLI 0.1.98. Signing establishes publisher identity; this is not a confirmed fix for that report and does not guarantee immediate SmartScreen reputation.
The implementation upgrades cargo-dist to 0.33.0, uses GitHub OIDC and a protected
releaseenvironment, and documents setup indocs/windows-signing.md. Missing signing configuration or failed verification stops the entire release.Validation: five Python configuration tests, 15 Windows signature-gate checks, actionlint, release planning for all five configured targets, and
git diff --checkpass. Signature tests include real unsigned rejection and mocked publisher/timestamp/trust failures. Existing local validation also exercised the gate with Microsoft-signed fixtures; that does not validate Wavedash signing.Keep this draft until Azure identity validation, the certificate profile, OIDC access, and GitHub environment configuration are complete. Production signing and a fresh Windows 11 installation with Smart App Control enabled have not been tested. No Azure resources have been created. This pipeline must not merge before setup because the next release would fail closed.
The installer-checksum change is a separate draft against
main. When combining them, embed checksums after packaging the signed executable and before signing the installer.