Repository navigation
unit.getAbilityByIndex: call BlzGetUnitAbilityByIndex - #504
Merged
Merged
Conversation
It called BlzGetUnitAbility(this, index), which looks the index up as an ability rawcode and returns null for every real index, so a loop over a unit's abilities stopped at index 0. item.getAbilityByIndex already calls the ByIndex native.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unit.getAbilityByIndex(index)calledBlzGetUnitAbility(this, index), which treats the index as an ability rawcode. It returns null for every real index, so code that walks a unit's abilities with it stops at index 0.item.getAbilityByIndexalready callsBlzGetItemAbilityByIndex, and the unit version now matches it.The wrapper has been wrong since #251. Castle Fight hit it after moving its sealed-ability-field loop onto the wrapper: no unit got its fields applied, so dummy-cast spells (Charm, Chain Shock, purges) stopped working.
No unit test: the wrapper is one native call and the interpreter has no mock for it.
grill typecheckpasses, andgrill testpasses 522/522.