Repository navigation
In-game tests: a rerun counts the checks it skips - #502
Conversation
Sections 23 and 26 test the first registration of a listener, which a second run in the same game can not repeat, so they skip themselves and said so in a note. The note now carries how many checks it skips and the summary adds them up, so the checks a rerun runs plus the checks it skips are what the first run ran.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3bd9382f3e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…t still compiles A required method on the public interface broke any class implementing it for setEventChecksReporter and its siblings. The default reports the plain note those reporters got before; the runner's own reporter overrides it to count. A test with a reporter of the old shape fails to compile without the default.
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Running the in-game suite a second time in the same game skips sections 23 and 26. They test the first registration of a listener, a listener can not be taken back, and so a second run can not repeat them. They said so in an INFO note, but the totals did not: the first run reported 103 checks and the second 97, with nothing saying where 6 went.
The note now carries the count (
skipped 4 checks: ...) and the summary adds them up:97/97 checks passed, 6 skipped. The checks a rerun runs plus the checks it skips are what the first run ran, so a rerun which loses a check without saying so can be told from one which skipped it on purpose.IngameChecksgetsskipped(int checks, string why)next tonote, which the two sections call instead ofnote. It has a default body, the plain note, so a reporter written before it existed still compiles; the runner's own reporter overrides it to count.Measured on the 3.0.0.24268 client in a test map, the suite twice in one game: 103 checks the first time, 97 plus 6 skipped the second. The six are the four checks of section 23 and the two of section 26. If one of those sections gains or loses a check without its count changing, that sum no longer holds.
grill test: 522 of 522, including a test with a reporter of the old shape.