Repository navigation
Support local and private dependencies - #84
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4089f642e6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: add8752a3c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ee1b54f318
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| } | ||
|
|
||
| override fun reset(uri: URIish?) = Unit |
There was a problem hiding this comment.
When a credential helper returns a stale or revoked credential, JGit invokes reset after the server rejects it before retrying authentication. This no-op leaves the helper unaware of the failure, so each subsequent fill can return the same invalid credential and private dependency operations cannot recover or trigger a fresh sign-in. The inspected git credential -h output explicitly lists reject alongside fill and approve; retain the filled credential and pass it to git credential reject here.
Useful? React with 👍 / 👎.
1 participant
Summary
file:dependency URLs by copying the source directory into_build/dependencieson install, excluding.gitand rejecting symlinks.grill install file:...refreshes only local dependencies and skips remote dependency and core JASS refreshes, allowing offline use.Acceptance criteria
Checks
./gradlew test— passed; the two symlink regression cases were skipped because this Windows environment does not allow creating symbolic links.git diff --check— passed.Known limitations