Repository navigation
Fix Windows and macOS CI hanging on Warcraft folder chooser - #1461
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new MapModelReuseTests constructed their RunMap probe without an explicit game executable. On Windows and macOS runners without Warcraft, its constructor opened a modal installation-directory chooser and blocked the test worker indefinitely. Linux skips installation discovery, and a local Warcraft installation masked the regression.
Give the compile-only probe an explicit fixture executable path, matching the existing run-map tests. Add a regression test that rejects Windows/macOS installation discovery and restores the finder services afterward.
Validation: the regression failed before the fix with RunProbe attempted Windows game discovery; all 52 MapModelReuseTests and MapRequestPatchTargetTests pass after it (32s). The full Windows suite passes on the fixed head: 2,591 tests, zero failures, roughly 4 minutes with two forks and CI JVM options. macOS has not been executed locally.