Repository navigation
Update JMPQ3 for indexed lookups and parallel compression - #1456
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Map builds still used JMPQ3 v2.0.1, missing the indexed archive/writer lookups and parallel deflate sectors merged in inwc3/JMPQ3#58. Pin upstream commit
a7a771b48ba190f0e8734d20249efc1d72d2ed3astrictly so wc3libs' transitive v2.0.1 request cannot win Gradle version selection. The compiler's existing recompression path picks up parallel deflate automatically.Route the five known JitPack-only modules directly to JitPack in settings. Dependency validation otherwise timed out probing Google Maven for these GitHub artifacts before reaching their actual repository. Maven Central dependencies, including juniversalchardet, retain their existing resolution path.
Validation:
dependencyInsight --dependency JMPQ3 --configuration runtimeClasspathconfirms both the direct dependency and wc3libs resolve to the pinned commit.shadowJarpassed; compiler sources and test sources compiled successfully.MpqTest,CliBuildMapTests, andWurstBuildMapOutputTestspassed: 14 tests, zero failures or skips. The map-output test covers both Jass and Lua configuration output.