Repository navigation
Backlog: what a large map's build still spends, and the updateModel scan off the critical path - #1455
Merged
Merged
Conversation
…can off the critical path Records the costs measured but not changed while profiling a large map's build: the two per-file linear lookups in JMPQ3 behind the map config and the map data injection, single-threaded recompression of a release map, the Guava collections and copied dataflow states in the type check, and the per-subclass member lookups when translating methods to IM. And that keeping the WFile hash did not speed up a load, as the scan is off the critical path while parsing is parallel.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…low subclasses override the method themselves
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs only (BACKLOG.md). Records what was measured but not changed while profiling a large map's build with the corrected
-measure(#1452) and JFR, so the next round starts from the numbers:Applying Map Config(1.2 s) andInjecting map data(1.8 s) are mostly two JMPQ3 lookups which are linear per call and called once per file (MpqArchive.localesOf,MpqArchiveWriter.contains);Finalize map(7.8 s, release builds) recompresses every file on one thread. To be fixed in JMPQ3, then the pin bumped.getClassesWithImplementationis 20 %, a member lookup per method per subclass; how a faster version would have to be validated.updateModelscan item: keeping theWFilehash made the comparisons integer comparisons but did not change the load time, because the scan is off the critical path while parsing is parallel.