fix: ship the Claude plugin icon as PNG (0.1.0-canary.6) - #21
Merged
Merged
Conversation
The marketplace rejected .claude-plugin/icon.svg as ICON_INVALID because the generator embedded the PNG logo as a data-URI image inside the SVG. Ship assets/vllnt-logo.png as .claude-plugin/icon.png and name it with `icon` in plugin.json. Claude-Session: https://claude.ai/code/session_01VhX66NukkK9PC2hT9Zp8h1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Claude marketplace rejected
.claude-plugin/icon.svgwithICON_INVALID. The generator wrapped the PNG logo as a base64data:<image>inside the SVG, and listings reject SVGs that embed images. The listing therefore fell back to the GitHub avatar.Fix
scripts/sync.py: replaceicon_svgwithicon_png, which checks for a square PNG of at least 128px that is at most 2 MiB. The Claude package now ships.claude-plugin/icon.png, andplugin.jsonsets"icon": "./.claude-plugin/icon.png".0.1.0-canary.6. README and CHANGELOG are updated, and README records the remaining evidence gap.Verification
python3 -m unittest discover -s tests -v: 38 tests OK. The updated tests fail on the old generator.python3 scripts/sync.py --checkandgit diff --checkpass.claude plugin validate --strictpasses forplugins/claudeand for the marketplace.https://claude.ai/code/session_01VhX66NukkK9PC2hT9Zp8h1