Repository navigation
Conversation
Rotated strong free-slip is the recommended free-slip condition, so it must hold whatever the constitutive model. Nothing was broken -- a probe matrix of viscous, viscoplastic (constant and pressure-dependent yield), viscoelastic-plastic (BDF, ETD, yield, deformation step, log-conformation) and transversely isotropic VEP, in Stokes and Eulerian Navier-Stokes, on a box and an annulus, converged at every step in serial and on 2 ranks -- so this records the guarantee rather than a fix: - box: rms(v . Gamma)/rms(v) below 1e-12 for every rheology and solver; - annulus: the constraint holds at the nodes along their nodal normals, so v . Gamma against the facet normal is the polygonal boundary's geometric error (first order in h: 8.2e-2, 4.6e-2, 2.4e-2 at h = 1/4, 1/8, 1/16), the same for every model; each is held to the viscous value on the same mesh (within 25 %). 26 cases, about 2 minutes on 8 workers. Underworld development team with AI support from Claude Code
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rotated strong free-slip is the free-slip condition we recommend, so it has to hold whatever the constitutive model. This adds the test that says it does.
A probe matrix over viscous, viscoplastic (constant and pressure-dependent yield), viscoelastic-plastic (BDF, ETD, with yield, the deformation step, the log-conformation history) and transversely isotropic VEP, in
Stokesand the EulerianNavierStokes, on a box and an annulus, converged at every step in serial and on 2 ranks — nothing needed fixing.tests/test_1018_rotated_freeslip_every_rheology.py(level_2, tier_b, 26 cases, ~2 min on 8 workers) records it:Not covered here:
preconditioner_flux="model"is refused on the rotated path (onfeature/ve-stretch-split, which lands after #800); the adjoint of a rotated solve is #846.Checklist (UW3 Style Charter — docs/developer/UW3_STYLE_CHARTER.md)
level_*andtier_*markers (S8)maybe_/try_/do_) and no commented-out code (S3, S4).array/mesh.X.coords— nowith ....access(...), nomesh.data(S7)pixi.toml/pixi.lockor other dependency changes riding in an unrelated PRUnderworld development team with AI support from Claude Code