Skip to content

fix: expose hub content script chunk to selection-command.com - #493

Merged
ujiro99 merged 1 commit into
mainfrom
fix/hub-content-script-war
Oct 13, 2026
Merged

ujiro99 merged 1 commit into
mainfrom
fix/hub-content-script-war

Conversation

@ujiro99

@ujiro99 ujiro99 commented Oct 13, 2026

Copy link
Copy Markdown
Owner

crxjs keys content scripts by file path, so registering src/new_command_hub.tsx in two content_scripts entries made the later entry overwrite the earlier one. web_accessible_resources was then generated only for *.siro-cola.workers.dev, and the dynamic import of the hub chunk failed on selection-command.com in production builds.

Merge the two entries into one and narrow it with include_globs so the injected URLs stay the same.

crxjs keys content scripts by file path, so registering
src/new_command_hub.tsx in two content_scripts entries made the later
entry overwrite the earlier one. web_accessible_resources was then
generated only for *.siro-cola.workers.dev, and the dynamic import of
the hub chunk failed on selection-command.com in production builds.

Merge the two entries into one and narrow it with include_globs so the
injected URLs stay the same.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Oct 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.16%. Comparing base (fbf049b) to head (efea903).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #493   +/-   ##
=======================================
  Coverage   55.16%   55.16%           
=======================================
  Files         294      294           
  Lines       29904    29904           
  Branches     3048     3048           
=======================================
  Hits        16498    16498           
  Misses      13406    13406           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ujiro99
ujiro99 merged commit 5412f99 into main Oct 13, 2026
5 of 6 checks passed
@ujiro99
ujiro99 deleted the fix/hub-content-script-war branch October 13, 2026 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant