Repository navigation
fix: expose hub content script chunk to selection-command.com - #493
Merged
Merged
Conversation
crxjs keys content scripts by file path, so registering src/new_command_hub.tsx in two content_scripts entries made the later entry overwrite the earlier one. web_accessible_resources was then generated only for *.siro-cola.workers.dev, and the dynamic import of the hub chunk failed on selection-command.com in production builds. Merge the two entries into one and narrow it with include_globs so the injected URLs stay the same. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #493 +/- ##
=======================================
Coverage 55.16% 55.16%
=======================================
Files 294 294
Lines 29904 29904
Branches 3048 3048
=======================================
Hits 16498 16498
Misses 13406 13406 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crxjs keys content scripts by file path, so registering src/new_command_hub.tsx in two content_scripts entries made the later entry overwrite the earlier one. web_accessible_resources was then generated only for *.siro-cola.workers.dev, and the dynamic import of the hub chunk failed on selection-command.com in production builds.
Merge the two entries into one and narrow it with include_globs so the injected URLs stay the same.