Skip to content

Vouch request: SachinD6 — self-hosted local build API URL (#3258) #4981

Description

@SachinD6

Why do you want to contribute?

I'd like to fix #3258, which @matt-aitken scoped in his reply on that issue: an explicit build-time API URL override for local builds, the --network host option in the self-hosting docs, and the API URL plus HTTP status in the indexer's environment-variable error.

The change is ready on my fork: SachinD6/trigger.dev@main...fix/local-build-api-url

It adds --build-api-url / TRIGGER_BUILD_API_URL so a self-hosted local build can pin the URL the build container uses instead of the automatic localhost → host.docker.internal rewrite, reports the URL and HTTP status when the indexer cannot fetch environment variables, and documents --network host and the override. A patch changeset is included.

Verified locally: the packages/cli-v3 vitest suite (61 tests, including 4 new cases for the URL resolution), pnpm run build --filter trigger.dev, oxlint, oxfmt --check, and knip scoped to packages/cli-v3. deploy --help lists the flag. A stub docker on PATH shows the generated build args carry --build-arg TRIGGER_API_URL=<override> verbatim and skip the rewrite. I could not run a real self-hosted Docker build, since Docker is unavailable in this environment.

I'll open the PR as a draft once I'm vouched.

Prior contributions or relevant experience

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions