Repository navigation
Allow marking custom headers as sensitive on redirects - #177
Merged
Merged
Conversation
Member
Author
|
@CodeRabbit review |
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 52 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
floitsch
force-pushed
the
followup/redirect-sensitive-headers
branch
from
October 11, 2026 20:40
a038618 to
6e1bfc4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom credentials such as
X-Api-Keycurrently follow cross-origin redirects. Add--sensitive-headersto bothClientconstructors so callers can name additional headers to strip whenever the scheme, host, or port changes. Matching is ASCII case-insensitive; same-origin redirects retain credentials, and credentials removed during a chain are never restored. The configuration list is copied and caller-owned request headers remain unchanged.This is an additive policy: ordinary custom headers continue to be forwarded. Applications must list their custom credential headers (for example,
http.Client network --sensitive-headers=["X-Api-Key"]) or disable redirect following. The three standard credential headers remain unconditionally protected. This avoids introducing a restrictive allowlist that would break existing custom-header forwarding.Follow-up to #174: #174 (comment).
Validation on Toit v2.0.0-alpha.199:
ctest --test-dir build -j4 --output-on-failure -E 'google|webdriver', configured withENABLE_HTTPBIN_TESTS=OFF.git diff --checkpassed.Live Google, browser, and httpbin integration tests were not run locally. This PR targets merged main and can be reviewed independently of the downgrade-policy follow-up.