Skip to content

audio: module_adapter: ipc4: Allow probes module through channels check #11260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jsarha wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −2
Open

audio: module_adapter: ipc4: Allow probes module through channels check #11260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions src/audio/module_adapter/module_adapter_ipc4.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,20 @@ int module_ext_init_decode(const struct comp_driver *drv, struct module_ext_init
return 0;
}

/* Check if entire base config is all zero, as it is with probe module */
static bool is_probe_module(struct ipc4_base_module_cfg *base_cfg)
Comment on lines +129 to +130
{
const unsigned char *p = (const unsigned char *)base_cfg;
size_t s = sizeof(*base_cfg);

for (size_t i = 0; i < s; i++) {
if (p[i] != 0) {
return false;
}
}
return true;
}

/*
* \module adapter data initialize.
* \param[in] dev - device.
Expand Down Expand Up @@ -158,8 +172,9 @@ int module_adapter_init_data(struct comp_dev *dev,
dst->size = cfgsz;

/* Host-supplied channel count indexes PLATFORM_MAX_CHANNELS arrays. */
if (dst->base_cfg.audio_fmt.channels_count == 0 ||
dst->base_cfg.audio_fmt.channels_count > PLATFORM_MAX_CHANNELS) {
if ((dst->base_cfg.audio_fmt.channels_count == 0 ||
dst->base_cfg.audio_fmt.channels_count > PLATFORM_MAX_CHANNELS) &&
!is_probe_module(&dst->base_cfg)) {
comp_err(dev, "invalid channels count %u",
dst->base_cfg.audio_fmt.channels_count);
return -EINVAL;
Expand Down
Loading