Repository navigation
pr-build-zip: optional 'Try this PR in a live test site' link (central enrolment) - #119
Merged
Merged
Conversation
…rdPress Playground)
…pos.json), no per-repo caller change; optional base plugins
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The PR build comment can now include a link that opens a fresh WordPress (Playground, in the browser) with that PR's build installed and activated, logged in as admin. Aimed at QA verification and at support reproducing issues.
config/preview-link-repos.json. A repo not listed gets no link and no behaviour change. Enrolled today: onlythemegrill/user-registration.*-pro(14, open unlicensed), and themes needtype: theme. A link that looks right but fails is worse than none.preview-link: true|falseandpreview-*inputs let a caller override.continue-on-error; the script validates every value (the link is posted to a PR) and exits 0 with no output for non-enrolled repos.One-time infra change (already done)
themegrill-pr-artifactsCORS now allowsGET, HEADfromhttps://playground.wordpress.net. Verified: that origin is allowed, another origin is rejected.Testing
npm test: 68/68 (new: link builder + validation, enrolment resolution, running the script the way the workflow does).themegrill/user-registration(caller changed only to@feat/pr-preview-link+preview-tools-ref), manual dispatch -> success; link generated from that run's zip (HEAD 200, correct CORS); the real "Compose comment body" step rendered locally shows the link in the comment. Branch deleted.Not verified
requires(base-plugin install) andtype: themein a browser.Docs
CHANGELOG entry;
onboard-pr-build-zip-reposkill has an enrolment/testing section.