Repository navigation
ci: Use latest macOS runners and available simulators - #442
Merged
Merged
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
An unguarded diagnostic probe can terminate the failure-reporting script before its remaining sections run.
0 open findings
What changed in this PR
Updates macOS CI to track current runners/Xcode and dynamically resolve simulator runtimes.
Changes:
- Uses
macos-latest,latest-stableXcode, and simulator readiness actions. - Adds failure diagnostics for macOS workflows.
- Migrates Danger to the built-in token with scoped permissions.
| File | Description |
|---|---|
scripts/ci-utils.sh |
Adds CI logging helpers. |
scripts/ci-diagnostics.sh |
Collects macOS/Xcode diagnostics. |
.github/workflows/tests.yml |
Modernizes runners and simulator setup. |
.github/workflows/release.yml |
Updates runner and adds diagnostics. |
.github/workflows/documentation.yml |
Updates runner and adds diagnostics. |
.github/workflows/danger.yml |
Scopes permissions and migrates token usage. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
macos-latestfor all macOS workflows and the latest stable installed Xcode for tests. Replace custom simulator selection withkula-app/wait-for-services-action/ios-simulator@v1for iOS, tvOS, watchOS, and visionOS, passing its resolved runtime and the configured device to the existing Make targets.Migrate Danger to the built-in
GITHUB_TOKENwith job-scoped permissions. Add grouped, failure-only CI diagnostics adapted from sentry-cocoa, including its complete MIT license in both script headers.Verification
Test, documentation, and Danger workflows pass actionlint. Simulator action smoke checks with mocked simctl responses cover all four platforms, the visionOS/xrOS alias, and Make build/test destinations. Diagnostics smoke checks, ShellCheck, and commit hooks passed.
Danger passed hosted CI after the token migration. Hosted CI for the simulator action and diagnostics changes is pending. The release workflow retains pre-existing actionlint warnings for unquoted shell variables and an obsolete release action.