Repository navigation
Normalize JSON benchmark bodies. - #1388
Merged
Merged
Conversation
adwsingh
force-pushed
the
adwsingh/serde-benchmark-normalization
branch
from
October 8, 2026 01:44
aea4891 to
154ed22
Compare
adwsingh
force-pushed
the
adwsingh/serde-benchmark-normalization
branch
from
October 8, 2026 01:57
154ed22 to
cd0fb67
Compare
adwsingh
force-pushed
the
adwsingh/serde-benchmark-normalization
branch
from
October 8, 2026 03:30
cd0fb67 to
ee8201b
Compare
mtdowling
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What behavior changes?
JSON response bodies are minified during benchmark setup, while XML and opaque payloads retain their original bytes.
Why is this change needed?
Remove JSON formatting overhead from deserialization measurements without altering meaningful payload content.
How was this validated?
All 10 unit tests,
spotlessCheck,compileJmhJava, andjmhJarpassed; jar inspection confirmed one normalizer and no test classes.What should reviewers focus on?
Review media-type precedence and byte preservation in
WireBodyNormalizer, its integration inDeserializeState, and the JMH test exclusion.Additional Links
None.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.