Repository navigation
Build the site on pull requests without deploying - #297
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3aa701bf10
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ccd6d5a to
097c936
Compare
The Pages workflow only ran on pushes to main, so PRs (e.g. #236) merged without the site ever being built. Run the build on all pull requests, whatever their base branch, so stacked PRs are covered too. Deploy only for a push or manual run on main, and key the concurrency group by ref so a PR build can't cancel an in-progress deployment of main. Since the build job now runs PR-controlled code, it only gets read permissions; pages: write and id-token: write move to the deploy job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
097c936 to
a5876f2
Compare
1 participant
The Pages workflow only ran on pushes to
mainandworkflow_dispatch, so PRs never built the site. #236 (Ruby 4) merged with only the Mergify and CLA checks, and the deploy after it broke (see #296).Changes to
.github/workflows/pages.yml:pull_requesttrigger for all PRs, whatever their base branch, so stacked PRs are built too.deployjob only for a push or manual run onmain. Any other event, including PRs and any trigger added later, builds without deploying.pages-${{ github.ref }}) instead of the singlepagesgroup. Runs onmainstill cancel each other as before, but a PR build can't cancel an in-progress deployment ofmain.deployjob getspages: writeandid-token: write, because thebuildjob now runs PR-controlled code (Gemfile, Jekyll plugins).buildgetscontents: readandpages: read, whichconfigure-pagesneeds.Note:
mainis still on Ruby 4, which can't build the site, so this PR's build check will fail until #296 is merged. After that, this branch should be rebased so the check runs on Ruby 3.4.🤖 Generated with Claude Code