Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
CN-based synthetic DTX can transmit from sequence zero before the first real packet resets the sequence.
Review effort: Balanced
Findings: 1
What changed in this PR
Fixes a null dereference during DTX sequence initialization and adds regression coverage.
Changes:
- Initializes output sequencing only from non-null packets.
- Adds and registers a DTX/DTMF regression test.
| File | Description |
|---|---|
daemon/codec.c |
Guards sequence initialization against null packets. |
t/auto-daemon-tests-dtx-dtmf.pl |
Tests suppressed DTMF before initial audio. |
t/Makefile |
Registers the new daemon test. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| if (!mp->ssrc_out->seq_set) { | ||
| // Discard entries have no packet; initialize sequencing with the first real packet. | ||
| if (packet && !mp->ssrc_out->seq_set) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey folks,
DTMF suppression can pass a null packet into
__buffer_dtx()before the output RTP sequence is initialized. Dereferencingpacket->p.seqthen causes a segmentation fault.This patch defers sequence initialization until the first real packet arrives, while preserving discard tracking.
The regression test reproduces the crash on unpatched master and verifies that suppressed audio stays silent and subsequent audio uses the correct sequence numbers. All 12 unit tests and 4,143 daemon assertions passed; existing extended DTX failures were unchanged from master.
Cheers!