v12

.cursorrules

@@ -0,0 +1,2 @@
+- Check AGENTS.md for instructions specifically for AI
+- Check README.md for instructions

.eslintrc.js

@@ -0,0 +1,24 @@
+module.exports = {
+  env: {
+    browser: true,
+    commonjs: true,
+    es6: true,
+    node: true,
+  },
+  extends: "eslint:recommended",
+  ignorePatterns: ["dist/"],
+  globals: {
+    Atomics: "readonly",
+    SharedArrayBuffer: "readonly",
+  },
+  parserOptions: {
+    ecmaVersion: 2020,
+  },
+  overrides: [
+    {
+      files: ["test/**/*.js"],
+      env: { mocha: true },
+    },
+  ],
+  rules: {},
+};

.github/workflows/browserstack.yml

@@ -54,6 +54,9 @@ jobs:
       - name: Test BrowserStack matrix selection
         run: pnpm run test:matrix
 
+      - name: Run unit tests
+        run: pnpm run build && pnpm run test:unit && pnpm run test:deploy
+
       - name: Prettier check (report only, no writes or commits)
         if: always()
         run: |

AGENTS.md

@@ -0,0 +1,23 @@
+# Agent instructions
+
+Before working here, read the shared [Simple Analytics instructions](https://github.com/simpleanalytics/ide-config/blob/main/AGENTS.md) through the approved GitHub access method. Apply them alongside applicable parent and nested instructions; more specific instructions take precedence.
+
+## Tracker changes
+
+1. **Minimize shipped bytes.** Keep changes small and reuse existing helpers and variables. Measure minified and gzip byte differences for affected scripts against the target branch using the same build and compression settings. Test proposed optimizations: extracting repeated strings can increase gzip size.
+
+2. **Preserve existing installations.** Unless the user explicitly accepts a behavior change, preserve existing settings and integrations. Check affected combinations against the [customer documentation](https://docs.simpleanalytics.com/), including manual pageviews, query handling, attribution, namespaces, ignored metrics, metadata, and automatic events. Report concrete before/after effects on customer data, event names, and counts, separately from additions that leave existing installations unchanged.
+
+3. **Prefer simple implementations.** Add fallbacks, polling, abstractions, or compatibility layers only for a demonstrated requirement. Respect explicitly accepted tradeoffs, especially for unused beta helpers, rather than adding speculative compatibility machinery.
+
+4. **Preserve website behavior.** Tracking must respect cancelled actions, existing handlers, form validation, submitter settings, modified clicks, new tabs, and downloads. Let the browser or website own navigation and submission; send tracking without forcing either action.
+
+5. **Keep collection deliberate.** Honor collection settings and opt-outs. Distinguish query-parameter names from values when checking what is sent. Keep form field values out of automatic form tracking, sanitize automatically reported URLs, and keep extra diagnostic requests such as 404 confirmation opt-in. Make changes to collection defaults explicit for review.
+
+6. **Preserve browser and build compatibility.** Keep visitor-facing output ES5-compatible and respect feature boundaries such as event-free `light.js`. Build affected scripts from source and commit their generated distributions. Review source and build inputs first, using relevant generated output to verify those changes. Keep previously published pinned versions and their SRI bytes unchanged unless explicitly requested.
+
+## Validation and review
+
+7. **Verify affected behavior locally.** Use the Node and pnpm versions declared by the repository configuration and the commands available in `package.json`; see `README.md` for setup. For script changes, rebuild before focused before/after payload and browser-interaction checks. Prefer the offline suites in `test/unit/` for local runs. Follow the shared testing policy and ensure committed tests run with declared dependencies. Leave the full BrowserStack matrix to CI unless explicitly requested, and report local verification separately from remote CI.
+
+8. **Keep PRs easy to review.** Prefer one logical change per PR. Group related fixes under one issue, state dependencies and merge order, and branch from and target the integration branch requested by the user. Keep unrelated test-infrastructure repairs separate from tracker behavior changes.

README.md

@@ -16,7 +16,7 @@ As our public scripts are very important in our mission to privacy we decided to
 
 ## Contribute
 
-If you want to contribute, you probabaly want to contribute to our [`/src/default.js`](src/default.js) or [`/src/auto-events.js`](src/auto-events.js) files. These files compile into a few versions of our script by [`compile.js`](compile.js). They end up on [our CDN](https://scripts.simpleanalyticscdn.com/latest.js), custom domains, and [the Cloudflare app](https://www.cloudflare.com/apps/simpleanalytics).
+If you want to contribute, you probabaly want to contribute to our [`/src/default.js`](src/default.js) or [`/src/auto-events.js`](src/auto-events.js) files. These files compile into a few versions of our script by [`compile.js`](compile.js). They end up on [our CDN](https://scripts.simpleanalyticscdn.com/latest.js) and custom domains.
 
 In `default.js` you see some weird syntax in the comments. For example, `/** if ignorepages **/` _\[some code\]_ `/** endif **/`. These comments are converted to handlebars like this: `{{#if ignorepages }}` _\[some code\]_ `{{/if}}`. In this case, [`ignorepages` is a variable](https://github.com/simpleanalytics/scripts/blob/3874b44ce5f1b0b8a7d50fb512fdcf5285a0138f/minify.js#L66) used in `minify.js` that takes care of what functionality to show in what script. Our main script is the `latest.js` script which includes all features. We also have a `light.js` script that obviously doesn't.
 

compile.js

@@ -3,12 +3,13 @@ const UglifyJS = require("uglify-js");
 const fs = require("fs");
 const esprima = require("esprima");
 const path = require("path");
+const acorn = require("acorn");
 
 const GREEN = "\x1b[32m%s\x1b[0m";
 const YELLOW = "\x1b[33m%s\x1b[0m";
 const RED = "\x1b[31m%s\x1b[0m";
 
-const VERSION = 11;
+const VERSION = 12;
 
 Handlebars.registerHelper("or", function (param1, param2) {
   return param1 || param2;
@@ -24,7 +25,7 @@ const MINIFY_OPTIONS = {
   nameCache: null,
 };
 
-const fillTemplate = (template, { overwriteOptions = null } = {}) => {
+const fillTemplate = (template) => {
   if (!template)
     throw new Error("Parsing of the JavaScript failed, please use ES5 only.");
   return template
@@ -35,16 +36,6 @@ const fillTemplate = (template, { overwriteOptions = null } = {}) => {
     .replace(
       /\{\{\s?nginxProxyHost\s?\}\}/gi,
       '<!--# echo var="proxy_hostname" default="" --><!--# echo var="proxy_path" default="/simple" -->'
-    )
-    .replace(
-      /\\?"\{\{\s?overwriteOptions\s?\}\}\\?"/gi,
-      overwriteOptions
-        ? JSON.stringify(overwriteOptions).replace(/:"([^"]+)"/gi, ":$1")
-        : "{}"
-    )
-    .replace(
-      /"\{\{\s?cloudFlareCustomDomain\s?\}\}"/gi,
-      'INSTALL_OPTIONS.custom_domain || "queue.simpleanalyticscdn.com"'
     );
 };
 
@@ -77,7 +68,6 @@ const DEFAULTS = {
   nonuniquehostnames: true,
   ignoremetrics: true,
   dev: false,
-  skipnonwindow: false,
 };
 
 const LIGHT = {
@@ -156,36 +146,6 @@ const templates = [
       apiUrlPrefix: "queue.",
     },
   },
-  {
-    type: "js",
-    input: `${__dirname}/src/default.js`,
-    output: `cloudflare.js`,
-    variables: {
-      ...DEFAULTS,
-      skipnonwindow: true,
-      minify: false,
-      version: VERSION,
-      scriptName: `cloudflare_${VERSION}`,
-      sri: false,
-      baseUrl: "{{cloudFlareCustomDomain}}",
-      overwriteOptions: {
-        hostname: "INSTALL_OPTIONS.hostname",
-        collectDnt:
-          "typeof INSTALL_OPTIONS.collect_dnt === 'boolean' ? INSTALL_OPTIONS.collect_dnt : null",
-        mode: "INSTALL_OPTIONS.hash_mode ? 'hash' : 'normal'",
-        strictUtm:
-          "INSTALL_OPTIONS.advanced_settings_toggle && INSTALL_OPTIONS.strict_utm",
-        allowParams:
-          "INSTALL_OPTIONS.advanced_settings_toggle && INSTALL_OPTIONS.allow_url_parameters",
-        nonUniqueHostnames:
-          "INSTALL_OPTIONS.advanced_settings_toggle && INSTALL_OPTIONS.non_unique_hostnames",
-        ignorePages:
-          "INSTALL_OPTIONS.advanced_settings_toggle && INSTALL_OPTIONS.ignore_pages",
-        namespace:
-          "INSTALL_OPTIONS.overwrite_namespace && INSTALL_OPTIONS.namespace",
-      },
-    },
-  },
   {
     type: "js",
     input: `${__dirname}/src/default.js`,
@@ -308,10 +268,7 @@ for (const file of files) {
   const finalFileName = output.split("/").pop();
 
   const template = Handlebars.compile(contents);
-  const rawCode = template({
-    ...variables,
-    overwriteOptions: "{{overwriteOptions}}",
-  });
+  const rawCode = template(variables);
 
   const date = new Date().toISOString().slice(0, 10);
   const hash = require("crypto")
@@ -320,7 +277,7 @@ for (const file of files) {
     .digest("hex")
     .slice(0, 4);
 
-  const prepend = `/* Simple Analytics - Privacy friendly analytics (docs.simpleanalytics.com/script; ${date}; ${hash}${
+  const prepend = `/* Simple Analytics - Privacy-first analytics (docs.simpleanalytics.com/script; ${date}; ${hash}${
     variables.sri ? `; SRI-version` : ""
   }${variables.version ? `; v${variables.version}` : ""}) */\n`;
 
@@ -358,7 +315,32 @@ for (const file of files) {
   for (const warning of warnings || [])
     console.warn(YELLOW, `[${name}] ${warning}`);
 
-  const code = fillTemplate(codeTemplate, variables);
+  try {
+    acorn.parse(rawCode, { ecmaVersion: 5 });
+  } catch (error) {
+    // console.log("acorn", error);
+
+    // error object:
+    // pos: 147,
+    // loc: Position { line: 12, column: 0 },
+    // raisedAt: 148
+
+    // Find part of the code that is causing the error
+    const lines = rawCode.split("\n");
+    const line = error.loc.line;
+    const column = error.loc.column;
+    const start = Math.max(0, line - 3);
+    const end = Math.min(lines.length, line + 3);
+    const codeSnippet = lines.slice(start, end).join("\n");
+    const sentence = lines[error.loc.line - 1];
+
+    // console.log({ codeSnippet, line: lines[error.loc.line - 1] });
+
+    throw new Error(
+      `${error.message} at line ${sentence} position ${column}: ${codeSnippet}`
+    );
+  }
+  const code = fillTemplate(codeTemplate);
 
   const validate = template({
     ...variables,
@@ -385,7 +367,7 @@ for (const file of files) {
     fs.mkdirSync(path.dirname(latestFile), { recursive: true });
   }
 
-  const compiledMap = map ? fillTemplate(map, variables) : null;
+  const compiledMap = map ? fillTemplate(map) : null;
   const isCustom = /^custom\//.test(output);
 
   if (variables.version && variables.sri) {

deploy.mts

@@ -71,8 +71,8 @@ const CDN_PUBLIC_ROOT = "https://scripts.simpleanalyticscdn.com";
 const CDN_STORAGE_ROOT = "https://storage.bunnycdn.com/sa-cdn";
 const CDN_PURGE_URL =
   "https://api.bunny.net/purge?url=https://simpleanalyticscdn.b-cdn.net/*";
-const HEADER_PATTERN =
-  /^\/\* Simple Analytics - Privacy friendly analytics \(docs\.simpleanalytics\.com\/[^;]+; \d{4}-\d{2}-\d{2}; [0-9a-f]{4}(?:; SRI-version)?(?:; v\d+)?\) \*\/$/;
+export const HEADER_PATTERN =
+  /^\/\* Simple Analytics - Privacy(?: friendly|-first) analytics \(docs\.simpleanalytics\.com\/[^;]+; \d{4}-\d{2}-\d{2}; [0-9a-f]{4}(?:; SRI-version)?(?:; v\d+)?\) \*\/$/;
 
 const ansi = {
   bold: (value: string) => color("1", value),