fix: skip tables without annotation metadata when filtering query results - #1263
Open
FarisHrvat wants to merge 1 commit into
Open
FarisHrvat wants to merge 1 commit into
FarisHrvat wants to merge 1 commit into
Conversation
bounding_box_query and polygon_query with filter_table=True crashed on any table that has no spatialdata_attrs, even though such a table annotates nothing. Drop it instead, the same as filter_by_coordinate_system does by default (include_orphan_tables=False). Fixes scverse#1248
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1263 +/- ##
==========================================
+ Coverage 91.40% 91.42% +0.01%
==========================================
Files 53 53
Lines 8381 8381
==========================================
+ Hits 7661 7662 +1
+ Misses 720 719 -1
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1248
With
filter_table=True, bounding box and polygon queries crashed on any table withoutspatialdata_attrs. Such a table doesn't annotate anything, so it's now dropped, the same asfilter_by_coordinate_systemdoes by default (include_orphan_tables=False).