Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title suggests, rotating an assembled sub-level and then disassembling it can reverse a Rotation Speed Controller's output. The block axis is rotated during movement, but the signed
ScrollValueis copied unchanged, causing the rebuilt kinetic network to use the opposite direction. Video reproductionThe following turn can cause this problem:
A related issue: Creators-of-Aeronautics/Simulated-Project#968
This fix determines the controlled output axis from the kinetic source and negates the saved
ScrollValuewhen rotation reverses that axis's positive direction. Both shaft-powered and cog-powered configurations are supported.After fixing, manual in-game testing confirmed that the problem no longer occurs.