Skip to content

fix: speed controller cannot rotate to correct direction sometimes after disassembly - #1602

Open
Vaelow233 wants to merge 1 commit into
ryanhcode:mainfrom
Vaelow233:main
Open

Vaelow233 wants to merge 1 commit into
ryanhcode:mainfrom
Vaelow233:main

Conversation

@Vaelow233

Copy link
Copy Markdown

As the title suggests, rotating an assembled sub-level and then disassembling it can reverse a Rotation Speed Controller's output. The block axis is rotated during movement, but the signed ScrollValue is copied unchanged, causing the rebuilt kinetic network to use the opposite direction. Video reproduction

The following turn can cause this problem:

  • north -> east, 90°, clockwise
  • south -> west, 90°, clockwise
  • west -> south, 90°, anticlockwise
  • east -> north, 90°, anticlockwise
  • any 180° turn between opposite horizontal directions

A related issue: Creators-of-Aeronautics/Simulated-Project#968

This fix determines the controlled output axis from the kinetic source and negates the saved ScrollValue when rotation reverses that axis's positive direction. Both shaft-powered and cog-powered configurations are supported.

After fixing, manual in-game testing confirmed that the problem no longer occurs.

@CLAassistant

CLAassistant commented Oct 1, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants