Repository navigation
Conversation
`irb --prompt` without a mode crashed with NoMethodError on nil.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #910
irb --prompt(also--prompt-modeand--prompt=) with no mode crashed inparse_optswithundefined method 'upcase' for nil (NoMethodError). It now raisesIRB::UndefinedPromptMode, the same error IRB already uses for an unknown mode such asirb --prompt bogus.Listing the available modes is left out: modes can still be added by
.irbrcafter option parsing, so the list isn't final at that point.Testing
test_prompt_optiontotest/irb/test_init.rb. It covers--prompt simple,--prompt-mode=inf-rubyand the missing-value case. On master it fails with theNoMethodError, and with this change it passes.bundle exec rake test: 411 tests, 0 failures, 0 errors (3 omissions).bundle exec rubocop lib/irb/init.rb test/irb/test_init.rb: no offenses.irb --promptnow printsUndefined prompt mode(). (IRB::UndefinedPromptMode).--prompt simple,--prompt=classic,--prompt-mode inf-rubyand--nopromptwork as before.