Repository navigation
feat(run-once): support concurrent explicit issue runs - #295
Merged
rochecompaan merged 42 commits intoOct 8, 2026
Merged
rochecompaan merged 42 commits into
rochecompaan merged 42 commits into
Conversation
9 tasks
rochecompaan
force-pushed
the
agent/issue-226-support-concurrent-explicit-run-once-invocations-implementation
branch
from
October 7, 2026 16:49
c8a3c4a to
cbb4a43
Compare
This was referenced Oct 7, 2026
rochecompaan
deleted the
agent/issue-226-support-concurrent-explicit-run-once-invocations-implementation
branch
October 8, 2026 07:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #226
Summary
Design:
docs/specs/2026-10-03-issue-226-support-concurrent-explicit-run-once-invocations-design.mdPlan:
docs/plans/2026-10-03-issue-226-support-concurrent-explicit-run-once-invocations.mdHuman review is required for ownership safety, recovery compatibility, Git mutation authority, and dependency changes. No PR merge or release is authorized.
Main reconciliation
A normal merge incorporated
origin/mainat83846f0into the preserved implementation branch. No history rewrite or force push occurred.The seven skill conflicts are resolved:
updateProjectSkills.2026.10.1, and matching file hashes.Dependency manifests, lockfiles, shrinkwrap, and the Nix dependency hash match main exactly. Runtime pins are Pi
1.0.2and pi-subagents0.75.0.Superpowers remains
6.4.2. Simple English remains1.2.0. No additional dependency resolution occurred during reconciliation.Validation
Refreshed immutable head:
c8a3c4a500ea53205e632353ee827e3f3203fe3a.All local commands ran in the preserved issue implementation worktree:
taskset -c 0-7 npm test: 2,323/2,323 passed.taskset -c 0-7 npm run test:run-once: 896/896 passed.npm run check:types,npm run check:architecture,npm run lint, andnpm run build: passed.npm --prefix site ciandnpm --prefix site test: passed, 13/13 tests.npm --prefix site audit --audit-level=high: passed, zero high or critical findings. Eleven moderate findings remain.npm run site:build: passed, 18 pages.1.3.13: pi-subagents0.75.0completed the existing one-child compatibility contract.node scripts/smoke-packed-artifact.mjs: passed, including installed Pi extension loading.nix build .#patchmill --print-build-logs: passed, 2,301 tests passed and two project-file-dependent tests skipped.scripts/update-npm-deps-hash.sh: passed without changing the dependency hash. Nix CLI help smoke passed.git diff --checkandgit diff --cached --check: passed.Local evidence is retained under
/tmp/issue-226-refresh-*.logand the plan's progress ledger. Prior evidence and interrupted ownership records remain intact.Real-process tests use IPC barriers, real Git, local bare remotes, and controlled host/Pi effects. They require no paid agents or live host mutations.
Coverage includes mixed-workflow overlap, same-issue contention, unrelated recovery, cancellation/resume, automatic exclusion, and expected-base host merges.
Documentation and mechanical skill updates use formatting, Markdown lint, direct review, installer checks, and builds. No new test asserts static text or dependency versions.
All three PR checks passed for this exact head in CI run 37623595991:
GitHub reports the open PR as
MERGEABLEwith aCLEANmerge state. No PR merge or release occurred.Security dependency amendment
The site audit gate initially failed on two pre-existing high advisories. The approved compatible lockfile update changes only:
sharp:0.35.4→0.35.5, with its required native binaries and libvips1.3.4companions. Addresses GHSA-wq5f-xc86-pv6w.source-map-js:1.2.1→1.2.2. Addresses GHSA-68fv-2mgg-jv7q.Astro, Starlight, site dependency ranges, and supported runtimes are unchanged. No force update or audit-gate bypass occurred.
Eleven moderate site findings remain for separate triage.
The refreshed root audit reports 15 existing findings: nine high, three moderate, and three low. Root dependencies match current main exactly.
The required CI audit gate covers the site. This reconciliation does not expand the approved dependency remediation scope or conceal the root findings.
Independent review and fixes
One fresh, shell-less reviewer inspected
cddfd6e..06eeb0f, the approved artifacts, all five Review Focus cases, and the complete change inventory.Its first deadline expired without a verdict. The same retained reviewer continued through the governed tool and completed the original review.
One ordered fix pass addressed three Important findings with exact-head reproductions and RED→GREEN regressions:
A cleanup-hook documentation finding was regraded Important because it defines external-service lifetime. The text distinguishes planning publication-time and legacy merge-time hooks.
The reviewed state, fixes, and original report remain preserved. These records are historical and are not relabeled as a review of the refreshed head.
Baseline reconciliation did not trigger an automatic second review. All local validation ran again after incorporation. Human PR review remains the final review gate.
Structure and deferred work
No unresolved Critical or Important finding remains from the independent review. New ownership, PR evidence, and cleanup responsibilities use focused adapters.
The legacy orchestrator exceeds 1,000 lines. A later narrow extraction of pre-agent ownership and selection is recommended.
A broad rewrite risks compatibility recursion and durable checkpoint order. No Minor finding remains deferred.
Rulings and residual risks
Human reviewer callouts
git.allowDirectLand: trueis rejected. Custom skills cannot authorize target-branch updates or agent-supplied merge completion.1.0.2and pi-subagents0.75.0. Installed extension loading passed in packed and Nix artifacts.Patchmill run cost
Prompt tokens include uncached input, cache reads, and cache writes. Cost is an estimate based on Pi's recorded model pricing and includes parent and subagent sessions.