Repository navigation
Conversation
The `render pgcli --help` example passed `--csv -q` through to pgcli, but those are psql options: pgcli rejects them with "No such option '--csv'", so copying the example fails before any connection is made. Use `--single-connection --less-chatty`, which pgcli accepts. The psql example keeps `--csv -q`, which is valid there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
render pgcli --helpexample passes--csv -qthrough to pgcli, but those are psql options. Real pgcli rejects them before connecting:This replaces the example with
--single-connection --less-chatty, two options pgcli accepts. The psql example keeps--csv -q, which is valid for psql. The--passthrough itself is unchanged.Motivation
Copying the documented example fails immediately, even with a healthy database.
How to verify
render pgcli --helpshows the new example.pgcli --single-connection --less-chatty -h 127.0.0.1 -p 1 ...gets past option parsing (it reachesconnection failed: ... Connection refused), whilepgcli --csv -q ...fails withNo such option '--csv'.pgcli <db> -- --single-connection --less-chattyopened a working session in manual testing.Release notes