feat(updater): silent background pre-download and instant install for Compose updater by codeiva11 · Pull Request #3220 · recloudstream/cloudstream

codeiva11 · 2026-09-26T05:51:51Z

Summary

Builds directly on top of the newly merged Compose updater (#3204) by introducing silent background pre-downloading and immediate installation from cached APKs with real-time in-app progress.

What this adds to the Compose updater

Silent Background Pre-download:
- In \ApkUpdater.kt, added \downloadSilently\ to fetch updates quietly in the background without UI interruption during automated checks (\AutoSearchForUpdate).
- The user is only prompted once the APK is fully downloaded and verified on disk.
Instant Installation from Cache:
- In \GithubViewModel.kt, clicking Update checks if the APK is already pre-downloaded in internal cache.
- If present, \ApkUpdater.installFromFile\ immediately writes to \PackageInstaller.Session\ without download wait times.
- Falls back gracefully to standard live download if cache is missing.
In-App Installation Progress in Compose:
- Added \GithubUpdateDialogState.InstallProgress\ to \MainActivityScreen.kt.
- Displays real-time 0%–100% horizontal progress while writing to the session.
- Re-enabled \AutoSearchForUpdate\ on \MainActivityScreen\ to allow automated background update discovery.
Cache Clean-up on Skip:
- When the user chooses Skip Update, the pre-downloaded APK is immediately deleted from the cache to preserve storage.

Verification

Tested compilation: ./gradlew compilePrereleaseDebugKotlin\ (Build Successful).
Verified Kotlin ABI compatibility: ./gradlew library:checkKotlinAbi\ (Passed).
Verified Unit Tests: ./gradlew testPrereleaseDebugUnitTest\ (Passed).

… Compose updater

Bnyro · 2026-10-01T09:08:13Z

+            if (tempFile.renameTo(targetFile)) {
+                targetFile
+            } else {
+                tempFile
+            }


Why should this rename fail? In case it's because targetFile could still exist, we should delete targetFile first.

Bnyro · 2026-10-01T09:10:36Z

+                        val installParams =
+                            PackageInstaller.SessionParams(PackageInstaller.SessionParams.MODE_FULL_INSTALL)
+
+                        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) {
+                            installParams.setRequireUserAction(PackageInstaller.SessionParams.USER_ACTION_NOT_REQUIRED)
+                        }
+                        installParams.setSize(length)


Suggested change

val installParams =

PackageInstaller.SessionParams(PackageInstaller.SessionParams.MODE_FULL_INSTALL)

if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) {

installParams.setRequireUserAction(PackageInstaller.SessionParams.USER_ACTION_NOT_REQUIRED)

}

installParams.setSize(length)

val installParams =

PackageInstaller.SessionParams(PackageInstaller.SessionParams.MODE_FULL_INSTALL)

if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) {

installParams.setRequireUserAction(PackageInstaller.SessionParams.USER_ACTION_NOT_REQUIRED)

}

installParams.setSize(length)

Please properly group code.

Bnyro · 2026-10-01T09:11:21Z


+        // If automated background search, download the update APK silently in advance
+        if (!fromUser) {
+            val activity = com.lagradost.cloudstream3.CommonActivity.activity


Suggested change

val activity = com.lagradost.cloudstream3.CommonActivity.activity

val activity = CommonActivity.activity

Bnyro · 2026-10-01T09:11:41Z

        )
+
+    private fun deleteCachedApk(tagName: String) {
+        val activity = com.lagradost.cloudstream3.CommonActivity.activity


Suggested change

val activity = com.lagradost.cloudstream3.CommonActivity.activity

val activity = CommonActivity.activity

Bnyro · 2026-10-01T09:13:37Z

+
+                        val receiverIntent = Intent(activity, PackageInstallerStatusReceiver::class.java)
+                        val flags = if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) {
+                            PendingIntent.FLAG_MUTABLE or PendingIntent.FLAG_UPDATE_CURRENT
+                        } else {
+                            PendingIntent.FLAG_UPDATE_CURRENT
+                        }
+                        val receiverPendingIntent = PendingIntent.getBroadcast(activity, 0, receiverIntent, flags)


Maybe it's possible to use PendingIntentCompat instead to simplify the code?

Bnyro · 2026-10-01T09:16:05Z

+                    var sessionId: Int? = null
+                    val packageInstaller = activity.packageManager.packageInstaller
+                    try {
+                        val installParams =
+                            PackageInstaller.SessionParams(PackageInstaller.SessionParams.MODE_FULL_INSTALL)
+
+                        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) {
+                            installParams.setRequireUserAction(PackageInstaller.SessionParams.USER_ACTION_NOT_REQUIRED)
+                        }
+                        installParams.setSize(length)
+
+                        sessionId = packageInstaller.createSession(installParams)
+                        val session = packageInstaller.openSession(sessionId)
+
+                        session.openWrite(activity.packageName, 0, length)
+                            .use { writeStream ->
+                                transfer(writeStream, inputStream, length, installProgress, null)
+                                session.fsync(writeStream)
+                            }
+
+                        val receiverIntent = Intent(activity, PackageInstallerStatusReceiver::class.java)
+                        val flags = if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) {
+                            PendingIntent.FLAG_MUTABLE or PendingIntent.FLAG_UPDATE_CURRENT
+                        } else {
+                            PendingIntent.FLAG_UPDATE_CURRENT
+                        }
+                        val receiverPendingIntent = PendingIntent.getBroadcast(activity, 0, receiverIntent, flags)
+                        session.commit(receiverPendingIntent.intentSender)
+                        session.close()
+                    } catch (t: Throwable) {
+                        sessionId?.let { id ->
+                            packageInstaller.abandonSession(id)
+                        }
+                        throw t
+                    }


This is all just copy and paste from packageInstallerDownloader, you should move it into a new, shared method instead of copy and pasting.

…group installParams, extract shared installer method

codeiva11 · 2026-10-05T10:39:24Z

Hi @Bnyro, thanks for the thorough review!

Addressed all feedback in b95fb41f:

renameTo fail - Added if (targetFile.exists()) targetFile.delete() before
enameTo() to handle existing target.
installParams grouping - Grouped into .apply { setRequireUserAction(...); setSize(...) } as suggested.
CommonActivity import - Added import com.lagradost.cloudstream3.CommonActivity and replaced FQN com.lagradost.cloudstream3.CommonActivity.activity with CommonActivity.activity in GithubViewModel.kt.
PendingIntent flags - Kept explicit SDK check for FLAG_MUTABLE vs FLAG_UPDATE_CURRENT (clearer than PendingIntentCompat for this case) and grouped consistently in the shared method.
Duplicate installer code - Extracted shared method installWithPackageInstaller() and made both packageInstallerDownloader() and installFromFile() delegate to it instead of copy-pasting.

Verification: ./gradlew :app:compilePrereleaseDebugKotlin\ SUCCESS, :library:checkKotlinAbi\ SUCCESS, CodeFactor SUCCESS.

Ready for re-review!

Bnyro · 2026-10-05T10:45:59Z

Either you're an AI agent or your copy-and-pasting conversations with an AI agent. Not worth my time.

feat(updater): silent background pre-download and instant install for…

26fbf95

… Compose updater

Bnyro reviewed Oct 1, 2026

View reviewed changes

fix: address review feedback - delete existing target before rename, …

b95fb41

…group installParams, extract shared installer method

Navigation Menu

feat(updater): silent background pre-download and instant install for Compose updater - #3220

feat(updater): silent background pre-download and instant install for Compose updater#3220
codeiva11 wants to merge 2 commits into
recloudstream:masterfrom
codeiva11:feat/silent-compose-updater

codeiva11 commented Sep 26, 2026

Uh oh!

Bnyro Oct 1, 2026

Uh oh!

Bnyro Oct 1, 2026

Uh oh!

Bnyro Oct 1, 2026

Uh oh!

Bnyro Oct 1, 2026

Uh oh!

Bnyro Oct 1, 2026 •

edited

Loading

Uh oh!

Bnyro Oct 1, 2026

Uh oh!

codeiva11 commented Oct 5, 2026

Uh oh!

Bnyro commented Oct 5, 2026 •

edited

Loading

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	val activity = com.lagradost.cloudstream3.CommonActivity.activity
	val activity = CommonActivity.activity

Conversation

codeiva11 commented Sep 26, 2026

Summary

What this adds to the Compose updater

Verification

Uh oh!

Bnyro Oct 1, 2026

Choose a reason for hiding this comment

Uh oh!

Bnyro Oct 1, 2026

Choose a reason for hiding this comment

Uh oh!

Bnyro Oct 1, 2026

Choose a reason for hiding this comment

Uh oh!

Bnyro Oct 1, 2026

Choose a reason for hiding this comment

Uh oh!

Bnyro Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Bnyro Oct 1, 2026

Choose a reason for hiding this comment

Uh oh!

codeiva11 commented Oct 5, 2026

Uh oh!

Bnyro commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Bnyro Oct 1, 2026 •

edited

Loading

Bnyro commented Oct 5, 2026 •

edited

Loading