feat: dynamic range compressor for dialogue boost / action limiting - #3117
Merged
fire-light42 merged 78 commits intoOct 5, 2026
Merged
Conversation
This class implements a real-time dynamic range compressor as an AudioProcessor, allowing for audio signal compression based on specified parameters. It includes methods for configuring audio format, processing input, and managing internal state.
Added support for dynamic range compression in audio sink.
Added a DynamicRangeCompressor instance to the audio sink for live parameter updates.
Contributor
Author
|
TESTING IS REMAINING = DRAFT FOR NOW |
Contributor
Author
|
It's almost done (Yeah it's W.I.P) |
Added constants for compressor settings in FullScreenPlayer.
Fix missing newline at the end of CS3IPlayer.kt
Added a new SwitchPreference for compressor settings.
Added new strings for compressor settings and updated existing ones.
Updated layout properties for compressor dialog and adjusted button configurations.
Contributor
Author
|
It's working now but needs little work |
Refactor compressor dialog handling and update UI elements for better readability and maintainability.
Contributor
Author
|
Fixed all points from the review:
Also fixed a build-breaking XML tag mismatch and a string formatting warning from CI. |
Contributor
Author
|
fixed typo |
Suppress deprecation warning for flush() method.
Contributor
Author
|
done! |
Collaborator
|
I will try to review tomorrow 👍 |
Contributor
Author
|
Whoops note for firelight I tired to make it competible with the new ui and the features option is gone I'm outside right now I cannot fix it can u do it for me while porting to new version |
Contributor
Author
|
Compatibile* |
Removed the 'compressor_enabled_key' string from resources.
Added newline characters for better formatting in legal notice text.
Contributor
Author
|
Trying to fix it i cannot figure out it |
Add newline at the end of SettingsPlayerScreen.kt
Contributor
Author
|
**I tested it and its finnally done! |
Collaborator
|
Apologies for the late review, I have been busy. I will try to review soon 👍 |
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a real-time dynamic range compressor accessible via a new
"Compressor" button next to Tracks in the player controls.
Ported from VLC's compressor.c (LGPL, Steve Harris / Ronald Wright).
Implemented as a Media3 AudioProcessor injected into DefaultAudioSink
— sits directly in the audio pipeline, zero overhead when disabled.
Controls: threshold, ratio, attack, release, makeup gain.
All adjustable live via sliders with no player reload needed.
Settings are persisted across sessions.
Defaults: threshold -14dB, ratio 4:1, attack 10ms, release 50ms,
makeup +6dB.
Works with both nextlib and default decoder paths.
Full TV remote navigation. Correctly included in isDialogOpen().
This PR was developed with AI assistance (Claude by Anthropic) for implementation and bug hunting. All code has been tested on a real Android TV device and a phone.