Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟡 Changes recommended
Cache rejection causes duplicate hitset construction, and automatic caching introduces linear seeking for selective intersections.
2 open findings
What changed in this PR
This PR prepares reusable regex and wildcard hitsets during search warmup to avoid rebuilding them during execution.
Changes:
- Adds automatic predicate caching and merges warmup cache keys.
- Builds compressed hitsets during warmup and rechecks the cache during scorer construction.
- Moves compilation onto the priority-aware search pool and updates Tantivy.
| File | Description |
|---|---|
| quickwit/quickwit-search/src/leaf.rs | Populates hitsets during warmup and schedules compilation. |
| quickwit/quickwit-query/src/query_ast/cache_node.rs | Adds automatic wrapping, bitset conversion, and cache rechecks. |
| quickwit/quickwit-doc-mapper/src/query_builder.rs | Collects cache keys while preserving postings-only prefilters. |
| quickwit/quickwit-doc-mapper/src/lib.rs | Exports the automaton warmup type. |
| quickwit/quickwit-doc-mapper/src/doc_mapper/mod.rs | Defines and merges automaton warmup requests. |
| quickwit/Cargo.toml | Updates Tantivy dependency revisions. |
| quickwit/Cargo.lock | Locks the updated Tantivy dependencies. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| &mut self, | ||
| regex_query: super::RegexQuery, | ||
| ) -> Result<Option<QueryAst>, Self::Err> { | ||
| self.transform_cache_node(CacheNode::new(QueryAst::Regex(regex_query))) |
Comment on lines
+618
to
+620
| let hits = HitSet::from_bitset(bitset); | ||
| for key in cache_keys { | ||
| cache.put(split_id.clone(), key, segment_id, hits.clone()); |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Populate the predicate cache during regex/wildcard warmup so search execution can reuse complete hitsets instead of rebuilding them with an automaton scorer. Subsequent queries can reuse the same per-split predicate hits across different filters and time ranges.
Changes
HitSet.c12cc2d5.No API or configuration changes. Scored queries and queries with predicate caching disabled retain postings-only warmup. This does not add in-flight deduplication between concurrent requests.
Verification
make fmtpassed.Fieldimport in query_builder.rs's test module.