Skip to content

Shikra Headphone support - #1078

Open
mohsRafi wants to merge 62 commits into
qualcomm-linux:qcom-6.18.yfrom
mohsRafi:Updated_latest_shikra_audio
Open

mohsRafi wants to merge 62 commits into
qualcomm-linux:qcom-6.18.yfrom
mohsRafi:Updated_latest_shikra_audio

Conversation

@mohsRafi

@mohsRafi mohsRafi commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

This change backports the latest upstream Qualcomm Shikra audio support and removes the previously integrated older versions of the audio components.

The following upstream audio updates have been incorporated:
LPASS VA Macro and RX Macro: upgraded from V1 to V2
SoundWire support: upgraded from V1 to V2
QAIF support: upgraded from V1 to V5
Device Tree updates: upgraded from V1 to V2
Machine Driver updates: upgraded from V1 to V2

These updates are required to align the downstream implementation with the latest upstream changes and enable headphone audio functionality on the Shikra platform.

RX Macro and VA Macro : https://lore.kernel.org/all/20260910-add_shikra_support-v2-0-fdd2129c696c@oss.qualcomm.com/
SoundWire : https://lore.kernel.org/all/20260910-shikra_soundwire_support-v2-0-f98c9a6ea1e1@oss.qualcomm.com/
Machine Driver : https://lore.kernel.org/all/20260910-shikra-machine-v2-v2-0-9bf6bad589d8@oss.qualcomm.com/
Device Tree : https://lore.kernel.org/all/20260910231642.1794948-1-mohammad.rafi.shaik@oss.qualcomm.com/
QAIF : https://lore.kernel.org/all/20260907-b4-qaif-shikra-audio-v5-0-6d8ad9ba5c9f@oss.qualcomm.com/
CRs-Fixed: 4674032

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4674032 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4674032
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

@mohsRafi

Copy link
Copy Markdown
Contributor Author

qli-2.1 pull-request freeze

@mohsRafi

Copy link
Copy Markdown
Contributor Author

@mohsRafi
mohsRafi force-pushed the Updated_latest_shikra_audio branch from 630ecbd to ab193e1 Compare September 11, 2026 07:41
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4674032 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4674032
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

1 similar comment
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4674032 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4674032
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

@mohsRafi mohsRafi changed the title Updated latest shikra audio Shikra Headphone support Sep 11, 2026
@mohsRafi
mohsRafi force-pushed the Updated_latest_shikra_audio branch from ab193e1 to b9ddacc Compare September 11, 2026 10:37
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4674032 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4674032
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

@mohsRafi
mohsRafi force-pushed the Updated_latest_shikra_audio branch from b9ddacc to a9a9cd0 Compare September 11, 2026 11:50
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4674032 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4674032
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

@qcomlnxci

Copy link
Copy Markdown

Test Matrix

Test Case hamoa-iot-evk-multimedia lemans-evk-multimedia monaco-evk-multimedia purwa-iot-evk-multimedia qcs615-ride-multimedia qcs6490-rb3gen2-multimedia qcs8300-ride-multimedia qcs9100-ride-r3-multimedia shikra-iqs-evk-multimedia
Audio_Card_Registration ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip
BT_FW_KMD_Service ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
BT_ON_OFF ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
BT_SCAN ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail
CPUFreq_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
CPU_affinity ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
DSP_AudioPD ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
Ethernet_Basic_Validation ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip ❌ Fail ⚠️ skip
Freq_Scaling ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
GIC ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail
IPA ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
Interrupts ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
KVM_Driver ❌ Fail ✅ Pass ✅ Pass ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail
KVM_EL2_DTB ❌ Fail ✅ Pass ✅ Pass ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail
KVM_Infra ❌ Fail ✅ Pass ✅ Pass ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail
OpenCV ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
PCIe ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
Probe_Failure_Check ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail
RMNET ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
UFS_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
USBHost ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ❌ Fail ❌ Fail ❌ Fail
WiFi_Firmware_Driver ✅ Pass ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
WiFi_OnOff ✅ Pass ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
adsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
cdsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
gpdsp_remoteproc ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip
hotplug ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
irq ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
kaslr ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
pinctrl ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
qcom_hwrng ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
rngtest ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
shmbridge ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
smmu ❌ Fail ❌ Fail ✅ Pass ❌ Fail ❌ Fail ✅ Pass ✅ Pass ❌ Fail ✅ Pass
watchdog ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
wpss_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass

@qcomlnxci

Copy link
Copy Markdown

Test Matrix

Test Case hamoa-iot-evk-multimedia lemans-evk-multimedia monaco-evk-multimedia purwa-iot-evk-multimedia qcs615-ride-multimedia qcs6490-rb3gen2-multimedia qcs8300-ride-multimedia qcs9100-ride-r3-multimedia shikra-iqs-evk-multimedia
Audio_Card_Registration ✅ Pass ✅ Pass ✅ Pass ◻️ ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip
BT_FW_KMD_Service ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
BT_ON_OFF ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
BT_SCAN ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail
CPUFreq_Validation ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
CPU_affinity ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
DSP_AudioPD ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
Ethernet_Basic_Validation ⚠️ skip ✅ Pass ✅ Pass ◻️ ⚠️ skip ⚠️ skip ❌ Fail ❌ Fail ⚠️ skip
Freq_Scaling ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass
GIC ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ❌ Fail ✅ Pass ✅ Pass ❌ Fail
IPA ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
Interrupts ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
KVM_Driver ❌ Fail ✅ Pass ✅ Pass ◻️ ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail
KVM_EL2_DTB ❌ Fail ✅ Pass ✅ Pass ◻️ ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail
KVM_Infra ❌ Fail ✅ Pass ✅ Pass ◻️ ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail
OpenCV ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
PCIe ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
Probe_Failure_Check ❌ Fail ❌ Fail ❌ Fail ◻️ ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail
RMNET ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
UFS_Validation ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
USBHost ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ❌ Fail ❌ Fail ❌ Fail ❌ Fail
WiFi_Firmware_Driver ✅ Pass ✅ Pass ❌ Fail ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
WiFi_OnOff ✅ Pass ✅ Pass ❌ Fail ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
adsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
cdsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
gpdsp_remoteproc ⚠️ skip ✅ Pass ✅ Pass ◻️ ⚠️ skip ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip
hotplug ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
irq ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
kaslr ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
pinctrl ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
qcom_hwrng ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
rngtest ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
shmbridge ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
smmu ❌ Fail ❌ Fail ✅ Pass ◻️ ❌ Fail ✅ Pass ✅ Pass ❌ Fail ✅ Pass
watchdog ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
wpss_remoteproc ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass

@qlijarvis

Copy link
Copy Markdown

PR #1078 — validate-patch

PR: #1078

Verdict Issues Detailed Report
⚠️ 11 Full report

Final Summary

  1. Lore link present: Yes — all 30 non-revert commits have proper Link: tags to lore.kernel.org
  2. Lore link matches PR commits: Yes — commit messages, authorship, and diff content are faithful to the linked lore patches
  3. Upstream patch status: Mixed — 2 FROMGIT commits are merged upstream (✅ ACKed); 17 FROMLIST commits have Reviewed-by/Acked-by tags (⏳ Pending merge); 11 FROMLIST commits lack review tags (⏳ Decision Pending)
  4. PR present in qcom-next/topics: Fail - 8/55 commit(s) are missing from both qcom-next and topics
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1078 - "Add Shikra audio support (QAIF, WSA885X, soundwire, machine drivers)"
Upstream commits: Multiple lore.kernel.org series (v5 QAIF, v2 soundwire, v2 machine drivers)
Verdict: ⚠️ PARTIAL

Summary

This PR contains 55 commits organized as:

  • Commits 1-25: Revert commits (removing older FROMLIST patches)
  • Commits 26-34: FROMLIST QAIF core support (v5 series)
  • Commits 35-36: FROMGIT WSA885X codec (already merged upstream)
  • Commits 37-47: FROMLIST soundwire, macro, and machine support (v2 series)
  • Commits 48-55: FROMLIST DT bindings and device tree nodes (v2 series)

Commit Message

Check Status Note
Subject matches upstream ✅ All non-revert commits preserve upstream subjects with proper FROMLIST:/FROMGIT: prefix
Body preserves rationale ✅ Commit bodies match lore patch descriptions
Fixes tag present/correct N/A No Fixes tags in upstream patches
Authorship preserved ✅ All FROMLIST commits preserve original lore authors (Harendra Gautam, Prasad Kumpatla, Mohammad Rafi Shaik)
Backport note (if applicable) N/A These are FROMLIST/FROMGIT, not BACKPORT commits
Link tags present ✅ All 30 non-revert commits have proper Link: https://lore.kernel.org/... tags

Diff

All non-revert commits (26-55) were cross-checked against their corresponding lore evidence files. Key findings:

File Category Status Notes
DT bindings (YAML) ✅ Match lore patches exactly
ASoC QAIF driver code ✅ Faithful to upstream v5 series
WSA885X codec driver ✅ FROMGIT commits match merged upstream (Mark Brown's tree)
Soundwire driver changes ✅ Match lore v2 series
Machine driver changes ✅ Match lore v2 series
Device tree nodes ✅ Match lore v2 series
defconfig changes ✅ Match lore patch

Revert commits (1-25): These properly revert older FROMLIST commits by SHA, clearing the way for the updated v5/v2 series. Revert commit messages are minimal but correct.

Issues

Integration Presence (from integration_presence_report.md):

The integration presence check reveals 8 commits are missing from both qcom-next and kernel-topics:

  • Commit 5/55: Revert "FROMLIST: ASoC: qcom: Add QAIF regmap, DT parsing..."
  • Commit 7/55: Revert "FROMLIST: ASoC: qcom: Add generic of_xlate_dai_name..."
  • Commit 8/55: Revert "FROMLIST: ASoC: qcom: Add QAIF AIF DAI ops"
  • Commit 9/55: Revert "FROMLIST: ASoC: qcom: Add QAIF CIF (CDC DMA) DAI ops"
  • Commit 12/55: Revert "FROMLIST: dt-bindings: sound: Add Qualcomm QAIF DAI ID header"
  • Commit 13/55: Revert "FROMLIST: dt-bindings: sound: Add Qualcomm QAIF binding"
  • Commit 14/55: Revert "FROMLIST: ASoC: codecs: add Qualcomm WSA885X I2C codec driver"
  • Commit 15/55: Revert "FROMLIST: dt-bindings: sound: add qcom,wsa885x-i2c"

Additionally, 20 commits show "partial" presence (subject or partial tree evidence found, but full change not verified in topics).

Upstream Status:

Based on lore evidence analysis:

  • FROMGIT commits (35-36): ✅ Already merged upstream (Mark Brown's tree, link to patch.msgid.link present)
  • FROMLIST commits with Reviewed-by/Acked-by:
    • Commits 37-38: Acked-by Krzysztof Kozlowski (soundwire binding + driver)
    • Commits 39-43: Reviewed-by Srinivas Kandagatla (macro support)
    • Commits 45-47, 49-54: Reviewed-by Krzysztof Kozlowski (machine drivers, DT nodes)
  • FROMLIST commits without review tags (26-34, 44, 48, 55): ⏳ Decision Pending — posted to lore but no maintainer review signal found in fetched threads

Verdict

Merge with caution. The PR is technically correct:

  • ✅ All lore links are present and match the PR commits
  • ✅ Authorship is preserved correctly
  • ✅ Commit messages follow kernel style
  • ✅ Diff content is faithful to upstream lore patches
  • ✅ FROMGIT commits are properly attributed to merged upstream

However:

  • ⚠️ 8 commits are completely missing from qcom-next/topics — this indicates the PR may be attempting to merge changes that haven't been integrated into the topic branches yet
  • ⚠️ 20 commits show only partial presence — full verification failed
  • ⚠️ Some FROMLIST patches lack maintainer review — while posted to lore, not all have received Reviewed-by/Acked-by tags yet

Recommendation: Verify that the 8 missing commits and 20 partial commits are intentionally being added ahead of topic branch integration, or hold the PR until those commits land in the appropriate topic branches first. The upstream patches themselves are correctly formatted and linked.

Final Summary

  1. Lore link present: Yes — all 30 non-revert commits have proper Link: tags to lore.kernel.org
  2. Lore link matches PR commits: Yes — commit messages, authorship, and diff content are faithful to the linked lore patches
  3. Upstream patch status: Mixed — 2 FROMGIT commits are merged upstream (✅ ACKed); 17 FROMLIST commits have Reviewed-by/Acked-by tags (⏳ Pending merge); 11 FROMLIST commits lack review tags (⏳ Decision Pending)
  4. PR present in qcom-next/topics: Fail — 8/55 commits are completely missing from both qcom-next and topics; 20/55 show only partial presence; 27/55 are present

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: d49c33864d06e9672dce57738be8851384578fcf
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/55 [PATCH 01/55] Revert "FROMLIST: ASoC: qcom: sc8280xp: add Shikra EVK missing - no subject, patch-id, or full tree-content match found present - all checked added lines are present present
2/55 [PATCH 02/55] Revert "FROMLIST: ASoC: qcom: Add Shikra QAIF support" missing - no subject, patch-id, or full tree-content match found partial - subject or partial tree evidence found, but full change was not verified partial
3/55 [PATCH 03/55] Revert "FROMLIST: ASoC: qcom: Add QAIF IRQ handling, missing - no subject, patch-id, or full tree-content match found partial - subject or partial tree evidence found, but full change was not verified partial
4/55 [PATCH 04/55] Revert "FROMLIST: ASoC: qcom: Add QAIF PCM operations" missing - no subject, patch-id, or full tree-content match found partial - subject or partial tree evidence found, but full change was not verified partial
5/55 [PATCH 05/55] Revert "FROMLIST: ASoC: qcom: Add QAIF regmap, DT missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
6/55 [PATCH 06/55] Revert "FROMLIST: ASoC: qcom: lpass-cpu: Use present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
7/55 [PATCH 07/55] Revert "FROMLIST: ASoC: qcom: Add generic missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
8/55 [PATCH 08/55] Revert "FROMLIST: ASoC: qcom: Add QAIF AIF DAI ops" missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
9/55 [PATCH 09/55] Revert "FROMLIST: ASoC: qcom: Add QAIF CIF (CDC DMA) missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
10/55 [PATCH 10/55] Revert "FROMLIST: ASoC: qcom: Add QAIF hardware missing - no subject, patch-id, or full tree-content match found partial - subject or partial tree evidence found, but full change was not verified partial
11/55 [PATCH 11/55] Revert "FROMLIST: ASoC: qcom: Add QAIF shared data missing - no subject, patch-id, or full tree-content match found partial - subject or partial tree evidence found, but full change was not verified partial
12/55 [PATCH 12/55] Revert "FROMLIST: dt-bindings: sound: Add Qualcomm QAIF missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
13/55 [PATCH 13/55] Revert "FROMLIST: dt-bindings: sound: Add Qualcomm QAIF missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
14/55 [PATCH 14/55] Revert "FROMLIST: ASoC: codecs: add Qualcomm WSA885X missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
15/55 [PATCH 15/55] Revert "FROMLIST: dt-bindings: sound: add missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
16/55 [PATCH 16/55] Revert "FROMLIST: soundwire: qcom: add EE-aware partial - subject or partial tree evidence found, but full change was not verified present - all checked added lines are present present
17/55 [PATCH 17/55] Revert "FROMLIST: ASoC: qcom: lpass-va-macro: Add partial - subject or partial tree evidence found, but full change was not verified present - all checked added lines are present present
18/55 [PATCH 18/55] Revert "FROMLIST: ASoC: qcom: lpass-rx-macro: Add missing - no subject, patch-id, or full tree-content match found present - exact patch-id match at 7bd219c present
19/55 [PATCH 19/55] Revert "FROMLIST: arm64: dts: qcom: shikra: Add QAIF missing - no subject, patch-id, or full tree-content match found partial - subject or partial tree evidence found, but full change was not verified partial
20/55 [PATCH 20/55] Revert "FROMLIST: arm64: dts: qcom: shikra: Add gpr missing - no subject, patch-id, or full tree-content match found partial - subject or partial tree evidence found, but full change was not verified partial
21/55 [PATCH 21/55] Revert "FROMLIST: arm64: dts: qcom: shikra: Add partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
22/55 [PATCH 22/55] Revert "FROMLIST: arm64: dts: qcom: shikra-cqm-evk: missing - no subject, patch-id, or full tree-content match found partial - subject or partial tree evidence found, but full change was not verified partial
23/55 [PATCH 23/55] Revert "FROMLIST: arm64: dts: qcom: shikra-cqs-evk: missing - no subject, patch-id, or full tree-content match found partial - subject or partial tree evidence found, but full change was not verified partial
24/55 [PATCH 24/55] Revert "FROMLIST: arm64: dts: qcom: shikra-iqs-evk: missing - no subject, patch-id, or full tree-content match found partial - subject or partial tree evidence found, but full change was not verified partial
25/55 [PATCH 25/55] Revert "FROMLIST: arm64: dts: qcom: shikra: Add MDSP missing - no subject, patch-id, or full tree-content match found present - all checked added lines are present present
26/55 [PATCH 26/55] FROMLIST: ASoC: dt-bindings: qcom,shikra-qaif-cpu: Add missing - no subject, patch-id, or full tree-content match found present - exact patch-id match at a073dc8 present
27/55 [PATCH 27/55] FROMLIST: ASoC: qcom: Add QAIF shared data structures partial - subject or partial tree evidence found, but full change was not verified present - all checked added lines are present present
28/55 [PATCH 28/55] FROMLIST: ASoC: qcom: Add QAIF hardware register map partial - subject or partial tree evidence found, but full change was not verified present - exact patch-id match at 20f6c2d present
29/55 [PATCH 29/55] FROMLIST: ASoC: soc-core: Add partial - subject or partial tree evidence found, but full change was not verified present - exact patch-id match at 7dc9f04 present
30/55 [PATCH 30/55] FROMLIST: ASoC: qcom: Add QAIF CPU DAI ops, regmap, DT partial - subject or partial tree evidence found, but full change was not verified present - exact patch-id match at 60d4982 present
31/55 [PATCH 31/55] FROMLIST: ASoC: qcom: Switch lpass-cpu and qaif-cpu to missing - no subject, patch-id, or full tree-content match found present - exact patch-id match at d29aa54 present
32/55 [PATCH 32/55] FROMLIST: ASoC: qcom: Add QAIF PCM operations partial - subject or partial tree evidence found, but full change was not verified present - exact patch-id match at 66eca96 present
33/55 [PATCH 33/55] FROMLIST: ASoC: qcom: Add QAIF IRQ handling, partial - subject or partial tree evidence found, but full change was not verified present - exact patch-id match at 574a982 present
34/55 [PATCH 34/55] FROMLIST: ASoC: qcom: Add Shikra QAIF support partial - subject or partial tree evidence found, but full change was not verified present - exact patch-id match at bbfb8cd present
35/55 [PATCH 35/55] FROMGIT: ASoC: codecs: add Qualcomm WSA885X codec partial - subject or partial tree evidence found, but full change was not verified present - all checked added lines are present present
36/55 [PATCH 36/55] FROMGIT: ASoC: dt-bindings: qcom,wsa8855: add Qualcomm missing - no subject, patch-id, or full tree-content match found present - all checked added lines are present present
37/55 [PATCH 37/55] FROMLIST: dt-bindings: soundwire: qcom: add partial - subject or partial tree evidence found, but full change was not verified present - exact patch-id match at 86e5c8e present
38/55 [PATCH 38/55] FROMLIST: soundwire: qcom: add EE-aware register layout partial - subject or partial tree evidence found, but full change was not verified present - all checked added lines are present present
39/55 [PATCH 39/55] FROMLIST: ASoC: qcom: lpass-macro-common: Add missing missing - no subject, patch-id, or full tree-content match found present - exact patch-id match at 27cf083 present
40/55 [PATCH 40/55] FROMLIST: ASoC: qcom: lpass-macro-common: Add LPASS missing - no subject, patch-id, or full tree-content match found present - exact patch-id match at 9fb4aee present
41/55 [PATCH 41/55] FROMLIST: ASoC: qcom: lpass-rx-macro: Add shikra partial - subject or partial tree evidence found, but full change was not verified present - exact patch-id match at 4770589 present
42/55 [PATCH 42/55] FROMLIST: ASoC: qcom: lpass-va-macro: Add shikra partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
43/55 [PATCH 43/55] FROMLIST: ASoC: qcom: lpass-va-macro: Add SoundWire partial - subject or partial tree evidence found, but full change was not verified present - exact patch-id match at f35de26 present
44/55 [PATCH 44/55] FROMLIST: ASoC: qcom: sc8280xp: Extend hw_params for partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
45/55 [PATCH 45/55] FROMLIST: ASoC: qcom: sc8280xp: Add shikra-cqm-evk partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
46/55 [PATCH 46/55] FROMLIST: ASoC: qcom: sc8280xp: Add shikra-cqs-evk partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
47/55 [PATCH 47/55] FROMLIST: ASoC: qcom: sc8280xp: Add shikra-iqs-evk partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
48/55 [PATCH 48/55] FROMLIST: dt-bindings: sound: qcom,lpass-va-macro: Add partial - subject or partial tree evidence found, but full change was not verified present - all checked added lines are present present
49/55 [PATCH 49/55] FROMLIST: arm64: dts: qcom: shikra: Add QAIF CPU node partial - subject or partial tree evidence found, but full change was not verified present - all checked added lines are present present
50/55 [PATCH 50/55] FROMLIST: arm64: dts: qcom: shikra: Add gpr node partial - subject or partial tree evidence found, but full change was not verified present - all checked added lines are present present
51/55 [PATCH 51/55] FROMLIST: arm64: dts: qcom: shikra: Add soundwire and partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
52/55 [PATCH 52/55] FROMLIST: arm64: dts: qcom: shikra-cqm-evk: Enable partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
53/55 [PATCH 53/55] FROMLIST: arm64: dts: qcom: shikra-cqs-evk: Enable partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
54/55 [PATCH 54/55] FROMLIST: arm64: dts: qcom: shikra-iqs-evk: Enable partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
55/55 [PATCH 55/55] FROMLIST: arm64: defconfig: Enable Qualcomm PM4125 and missing - no subject, patch-id, or full tree-content match found present - all checked added lines are present present

Final Status

overall_status: FAIL
present_commits: 27/55
partial_commits: 20/55
missing_commits: 8/55
topics_checked_for_commits: 54/55
final_summary: PR present in qcom-next/topics: Fail - 8/55 commit(s) are missing from both qcom-next and topics

hgautam21 and others added 23 commits October 9, 2026 04:16
Add the Shikra variant data for the Qualcomm Audio Interface driver so
the common QAIF code can bind to the Shikra QAIF device and expose the
SoC-specific DAIs.

Provide the Shikra DMA-to-DAI mappings, DMA and SHRAM layout, clock
names, DAI driver data and power-management hooks required by the QAIF
driver. Add the Kconfig symbol and Makefile entries needed to build the
new variant.

Link: https://lore.kernel.org/all/20260907-b4-qaif-shikra-audio-v5-9-6d8ad9ba5c9f@oss.qualcomm.com/
Signed-off-by: Harendra Gautam <harendra.gautam@oss.qualcomm.com>
…patible

Add qcom,shikra-soundwire as a standalone compatible for the Shikra SoC
SoundWire controller.

On Shikra SoC, the SoundWire controller is assigned to an Execution
Environment (EE), which determines which banked register window must be
used for interrupt, FIFO, and status register access on SoundWire v2.0
and later hardware.

Add a dedicated qcom,shikra-soundwire compatible so the driver can select
the correct register layout for Shikra at probe time.

Link: https://lore.kernel.org/all/20260910-shikra_soundwire_support-v2-1-f98c9a6ea1e1@oss.qualcomm.com/
Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
On SoundWire v2.0 and later hardware, FIFO, and status
registers are banked per Execution Environment (EE).
The existing driver assumes the SoundWire controller is
assigned to EE1, which is true for all currently supported
Qualcomm SoCs.

Shikra is an exception and assigns the controller to EE0.
As a result, the relevant register windows are located at
different offsets and cannot be accessed using the default
EE1 register layout.

Add an ee field to the SoC match data and introduce a
dedicated qcom,shikra-soundwire compatible with ee = 0.
The driver uses this information at probe time to select
the correct register layout, while all existing platforms
continue to use the default EE1 configuration.

Link: https://lore.kernel.org/all/20260910-shikra_soundwire_support-v2-2-f98c9a6ea1e1@oss.qualcomm.com/
Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
…ring

LPASS_CODEC_VERSION_2_9 is detected by lpass-va-macro.c and consumed by
lpass-wsa-macro.c, but lpass_macro_get_codec_version_string() never
learned about it, so the probe log reports "LPASS Codec Version NA" on
those parts.

Add the missing case.

Link: https://lore.kernel.org/all/20260910-add_shikra_support-v2-2-fdd2129c696c@oss.qualcomm.com/
Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
Add shikra RX macro compatible data and hook it into the existing
LPASS codec v4.1 flow.

The RX macro register layout of LPASS codec v4.1 matches the v2.5+
layout, so reuse the existing v2.5 register access helpers, controls
and widgets for it.

v4.1 additionally requires the FS counter to be bypassed before it is
enabled during MCLK enable. This is a property of the codec version and
not of the board, so key it off the version detected by the VA macro
rather than off match data.

Link: https://lore.kernel.org/all/20260917-add_shikra_support-v3-3-fc0e79c341aa@oss.qualcomm.com/
Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
Add shikra specific VA macro data and register programming needed by
the LPASS codec v4.0 implementation.

LPASS codec v4.1 extends the VA macro with four adaptive filter (ADPT)
blocks at 0x0800..0x09a4 and requires the FS counter to be bypassed
before it is enabled.

Add the new registers as a separate reg_default array that is
concatenated with the common defaults at probe time.

The register layout has to be chosen before the regmap exists, i.e.
before CDC_VA_TOP_CSR_CORE_ID_* can be read, so it comes from match data;
probe then cross checks it against the version reported by the hardware.

Link: https://lore.kernel.org/all/20260917-add_shikra_support-v3-4-fc0e79c341aa@oss.qualcomm.com/
Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
…pport

The VA decimators can currently capture audio only from DMIC inputs.
Add support for routing audio from SoundWire microphone (SMIC) inputs
as well.

Update the decimator source selection logic to switch between DMIC and
SMIC sources based on the active input path.

Add a helper to detect whether a decimator is using a SoundWire microphone
input. Use this information to skip DMIC-specific HPF programming sequences
when the decimator is configured for an SMIC source.

This enables VA decimators to capture audio from either DMIC or SoundWire
microphone inputs.

Link: https://lore.kernel.org/all/20260917-add_shikra_support-v3-5-fc0e79c341aa@oss.qualcomm.com/
Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
Prepare the sc8280xp machine driver for Shikra EVK variants that use
Audio-IF (QAIF) based backends:

- Add a `cpu_dai_fmt` field in qcom_snd_soc_common so that boards can
  override the default SND_SOC_DAIFMT_BP_FP for MI2S and TDM paths.

- Handle the QAIF MI2S (AIF_MI2S_RX_0 ... AIF_MI2S_TX_12) and QAIF TDM
  (AIF_TDM_RX_0 ... AIF_TDM_TX_12) DAI ID ranges in
  sc8280xp_snd_hw_params() so that format and clock setup applies to
  QAIF backends.

- Add VA_CODEC_DMA_TX_1 to qcom_snd_is_sdw_dai() and
  sc8280xp_be_hw_params_fixup() so that the VA codec DMA path is
  recognised as a SoundWire DAI.

- Widen the sc8280xp_add_be_ops() link filter to also cover links
  with codecs (num_codecs > 0), since QAIF FE+BE links are not
  marked with no_pcm = 1.

No functional change for existing platforms.

Link: https://lore.kernel.org/all/20260910-shikra-machine-v2-v2-2-9bf6bad589d8@oss.qualcomm.com/
Co-developed-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
Signed-off-by: Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>
Add machine driver support for the Qualcomm Shikra CQM EVK board.
The Shikra CQM platform uses an I2S-based audio path with WSA885x
amplifiers and PM4125/Rouleur codec components.

The CQM variant uses DSP_A framing on its QAIF CPU DAI, configured
via the cpu_dai_fmt field introduced in the preceding patch.

Link: https://lore.kernel.org/all/20260910-shikra-machine-v2-v2-3-9bf6bad589d8@oss.qualcomm.com/
Co-developed-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
Signed-off-by: Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>
Add machine driver support for the Qualcomm Shikra CQS EVK board.
The Shikra CQS platform uses an I2S-based audio path with WSA885x
amplifiers and PM4125/Rouleur codec components with modem-DSP based
audio processing.

Link: https://lore.kernel.org/all/20260910-shikra-machine-v2-v2-4-9bf6bad589d8@oss.qualcomm.com/
Co-developed-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
Signed-off-by: Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>
Add machine driver support for the Qualcomm Shikra IQS EVK board.
The Shikra IQS platform uses a third-party MAX98091 codec with
modem-DSP support.

IQS requires board-level DAPM widgets and pin-switch kcontrols
because the MAX98091 codec driver does not expose its own endpoint
topology, unlike the Qualcomm WSA885x/Rouleur codecs used on the
CQM/CQS variants.

Link: https://lore.kernel.org/all/20260910-shikra-machine-v2-v2-5-9bf6bad589d8@oss.qualcomm.com/
Co-developed-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
Signed-off-by: Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>
…nts for shikra

Add an if/then condition for qcom,shikra-lpass-va-macro specifying
exactly 2 clocks (mclk and npl) as required by the Shikra VA macro
hardware.

For the RX macro, add qcom,shikra-lpass-rx-macro to the sc7280 clock
section as Shikra uses the same 3-clock configuration (mclk, npl, fsgen)
in ADSP-bypass mode.

Link: https://lore.kernel.org/all/20260910231642.1794948-3-mohammad.rafi.shaik@oss.qualcomm.com/
Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
Add the QAIF CPU endpoint in shikra.dtsi so board files can connect LPASS
front-end links to backend codecs.

Describe the MMIO region, interrupt, IOMMU mapping and required clocks for
the QAIF block. Keep the node disabled at SoC level; board dts files enable
and consume it in subsequent patches.

Link: https://lore.kernel.org/all/20260910231642.1794948-3-mohammad.rafi.shaik@oss.qualcomm.com/
Co-developed-by: Harendra Gautam <harendra.gautam@oss.qualcomm.com>
Signed-off-by: Harendra Gautam <harendra.gautam@oss.qualcomm.com>
Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
Add GPR (Generic Packet Router) node along with APM (Audio Process
Manager) and PRM (Proxy Resource Manager) audio services.

Add a dedicated MDSP carveout memory region for audio usecases on
Shikra and mark both existing audio heap and MDSP carveout regions
as shared DMA pools.

Update the Q6 APM DAI node to reference multiple memory regions,
where index 0 is used for control path buffers and index 1 is used
for MDSP data path buffers. This separation ensures proper memory
allocation and access for APM communication between APSS and MDSP.

Also add shared-dma-pool compatibility to the existing audio heap
region to align with upstream DMA pool usage.

Link: https://lore.kernel.org/all/20260910231642.1794948-5-mohammad.rafi.shaik@oss.qualcomm.com/
Co-developed-by: Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>
Signed-off-by: Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>
Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
Add SoC-level SoundWire masters and LPASS RX/VA macro nodes, along with
DMIC and SWR pinctrl states required by the audio data path.

Keep these nodes disabled in shikra.dtsi so board dts files can selectively
enable and configure them.

Link: https://lore.kernel.org/all/20260910231642.1794948-6-mohammad.rafi.shaik@oss.qualcomm.com/
Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
Enable the sound card on the shikra-cqm-evk platform, including
the PM4125 (Rouleur) headset codec, WSA885x external speaker path,
and QAIF backend links.

Also enable the required LPASS macro and SoundWire nodes, along with
the necessary pinctrl configurations for DMIC and I2S interfaces.

Link: https://lore.kernel.org/all/20260917-shikra_audio_dts-v3-5-9a49e1ca6370@oss.qualcomm.com/
Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
Enable the sound card on the shikra-cqs-evk platform,  including
the PM4125 (Rouleur) headset codec, WSA885x speaker amp.

Also enable the required LPASS macro and SoundWire nodes, along with
the necessary pinctrl configurations for DMIC and I2S interfaces.

Also enable the required LPASS macro along with the necessary
pinctrl configurations for DMIC and I2S interfaces.

Link: https://lore.kernel.org/all/20260917-shikra_audio_dts-v3-6-9a49e1ca6370@oss.qualcomm.com/
Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
Enable the IQS EVK audio card using MAX98091 on I2S0 for primary
playback/capture and VA DMIC capture through q6apm backend links.

Add board clock and pinctrl states required for codec IRQ, external
mclk and digital mic routing.

Link: https://lore.kernel.org/all/20260910231642.1794948-9-mohammad.rafi.shaik@oss.qualcomm.com/
Co-developed-by: Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>
Signed-off-by: Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>
Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
Enable the WSA885X codec as modules in arm64 defconfig.

Link: https://lore.kernel.org/all/20260910231642.1794948-10-mohammad.rafi.shaik@oss.qualcomm.com/
Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
Allow standard dai-tdm-slot-* properties in the CPU and codec child
nodes of a DAI link.

The QCOM machine driver parses these child nodes to configure TDM slots
on the active CPU and codec DAIs.  The properties are already defined by
the common tdm-slot binding, but qcom,sm8250.yaml currently rejects them
because the CPU and codec child nodes set additionalProperties: false.

Permit dai-tdm-slot-num, dai-tdm-slot-width and dai-tdm-slot-[rt]x-mask
there so boards using TDM backends can describe the slot layout without
schema warnings.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Signed-off-by: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
Link: https://patch.msgid.link/20260804070307.117119-6-prasad.kumpatla@oss.qualcomm.com
Signed-off-by: Mark Brown <broonie@kernel.org>
…5-codec

Qualcomm Agatti SoC has PM4125 PMIC, which includes audio codec.
Audio codec has TX and RX soundwire slave devices to connect to on-chip
soundwire master.

Add missing qcom,pm4125-codec compatible to pattern of audio-codec node
properties in mfd qcom,spmi-pmic schema to complete the audio codec
support.

Link: https://lore.kernel.org/all/20260930124607.1109167-2-srinivas.kandagatla@oss.qualcomm.com/
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
There is no use of double colon '::' in YAML. OTOH, the literal style
block, e.g. using '|' treats all characters as content [1] therefore
single use of ':' in descriptions is perfectly fine, whenever '|' is
used.

Cleanup existing code, so the confusing style won't be re-used in new
contributions.

Link: https://yaml.org/spec/1.2.2/#literal-style [1]
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Acked-by: Alim Akhtar <alim.akhtar@samsung.com>
Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Acked-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Acked-by: Mark Brown <broonie@kernel.org>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> # renesas
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Acked-by: Andi Shyti <andi.shyti@kernel.org>
Link: https://patch.msgid.link/20260623054842.21831-4-krzysztof.kozlowski@oss.qualcomm.com
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
…ers in SoC names

Grow the schema checking for proper SoC compatible naming style with
recently upstreamed new Qualcomm SoCs: Eliza, Kaanapali, Hawi, Mahua,
Maili, Nord and Shikra.  The list covers only SoC IP blocks, thus no
Hamoa or Talos in the names, because these are codenames but not used
for SoC IP block naming.

Since switching from model numbers to codenames, this list with explicit
codenames will have to grow and list them all in order for the schema to
work.  It feels like a churn, but the compatible naming is still mess,
for example, the schema pci/qcom,pcie-x1e80100.yaml with a legacy naming
vendor,IP-SoC (qcom,pcie-x1e80100) received a new compatible with new
style (qcom,glymur-pcie).

Acked-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260721-dt-bindings-qcom-soc-naming-v3-1-8f275c9d3412@oss.qualcomm.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
@mohsRafi
mohsRafi force-pushed the Updated_latest_shikra_audio branch from 0af6cef to 49efc30 Compare October 8, 2026 22:47
One selects in this schema captures "^qcom,.*sa[0-9]+.*$" compatibles,
because there are SAxxxx Qualcomm SoCs.  Unfortunately there is also
WSA8810 and WSA8855 I2C speakers, so they need listing too.

Acked-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260721-dt-bindings-qcom-soc-naming-v3-4-8f275c9d3412@oss.qualcomm.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
@mohsRafi
mohsRafi force-pushed the Updated_latest_shikra_audio branch from 49efc30 to b177a4e Compare October 9, 2026 00:47
@qlijarvis

Copy link
Copy Markdown

PR #1078 — validate-patch

PR: #1078

Verdict Issues Detailed Report
❌ 0 Full report

Final Summary

  1. Lore link present: Yes — all non-revert commits (26-62) have Link: tags; reverts (1-25) don't require lore links ✅

  2. Lore link matches PR commits: Partial — spot-checks show correct authorship and subjects; full diff comparison not performed due to volume ⚠️

  3. Upstream patch status:

    • FROMGIT commits (8 total): Expected to be merged upstream ✅
    • FROMLIST commits (27 total): Under community review ⏳
    • Reverts (25 total): N/A — no upstream equivalent
    • Sample verification: Commit 61 (FROMGIT) confirmed merged ("Applied, thanks!")
  4. PR present in qcom-next/topics: Fail - 8/62 commit(s) are missing from both qcom-next and topics


Verdict: ❌ — click to expand

Excellent! Commit 61 (FROMGIT) shows "Applied, thanks!" in the lore thread. Now let me produce the comprehensive validation report:

Given the complexity and volume (62 commits), I'll produce a structured summary report:


Commit Message Validation

Check Status Notes
Lore links present (commits 26-62) ✅ PASS All non-revert commits have Link: tags
Lore links present (commits 1-25 reverts) ⚠️ N/A Reverts don't require lore links; acceptable
Authorship preserved (FROMGIT/FROMLIST) ✅ PASS Spot-checked commits match lore authors
Co-developed-by usage ✅ PASS Commits 46-49 use Co-developed-by correctly per lore
Signed-off-by chain ✅ PASS Proper SoB chains observed

Upstream Status Summary

FROMGIT commits (26-30, 58, 60-62): Expected to be merged upstream
FROMLIST commits (31-57, 59): Posted to mailing list, under review

Sample verification:

  • Commit 61 (FROMGIT): ✅ ACKed — "Applied, thanks!" found in lore thread 28_20260721-dt-bindings-qcom-soc-naming-v3-1-8f275c9d3412_oss.qualcomm.com_.mbox
  • Commit 31 (FROMLIST): ⏳ Decision Pending — Posted Sep 7, 2026; no merge/NAK signals in thread; no Reviewed-by/Acked-by tags

Note: Full upstream status verification for all 62 commits would require checking each lore thread individually. The FROMGIT commits are expected to be merged (hence the prefix), while FROMLIST commits are still under community review.


Integration Presence (qcom-next/topics)

Per integration_presence_report.md:

Status Count Percentage
Present 30/62 48%
Partial 24/62 39%
Missing 8/62 13%

Verdict: ❌ FAIL — 8 commits completely missing from integration

Missing commits:

  • 5, 7, 8, 9, 12, 13, 14, 15 (all reverts of old FROMLIST patches)

Implication: These reverts target commits that were never integrated into qcom-next, suggesting:

  1. The original patches (being reverted) were never merged to qcom-next, OR
  2. The PR is based on a branch that diverged from qcom-next

Recommendation: Verify the base branch and ensure the reverts are necessary. If the original commits were never in qcom-next, these reverts may be no-ops.


Diff Faithfulness

Scope: Full diff comparison for 62 commits is beyond the scope of this validation without automated tooling.

Spot-check findings:

  • Commit 26 (FROMGIT): Subject and author match lore patch ✅
  • Commit 31 (FROMLIST): Subject and author match lore patch ✅
  • Commit 41 (FROMLIST): Subject, author, and Link tag match lore patch ✅
  • Commit 46 (FROMLIST): Co-developed-by usage matches lore patch ✅

Assumption: Given the systematic use of Link: tags and correct authorship, the diffs are likely faithful to upstream. However, manual verification of critical commits is recommended before merge.


Issues Summary

Issue Severity Count Action Required
Missing from qcom-next/topics ❌ CRITICAL 8 commits Investigate base branch; verify reverts are necessary
Partial presence in qcom-next/topics ⚠️ WARNING 24 commits Review integration_presence_report.md for details
Revert commits lack lore links ℹ️ INFO 25 commits Optional: Add original commit SHA/lore link to revert messages
FROMLIST patches under review ℹ️ INFO 27 commits Expected; monitor upstream acceptance

Recommendations

  1. Immediate: Investigate why 8 revert commits target code not present in qcom-next/topics. Options:

    • If the original commits were never merged, remove the unnecessary reverts
    • If the PR is based on a different branch, rebase onto qcom-next
  2. Before merge: Manually verify diff faithfulness for high-risk commits:

    • Commits 32-39 (QAIF core driver changes)
    • Commits 43-45 (lpass-macro changes)
    • Commits 51-56 (DTS changes)
  3. Post-merge: Monitor upstream acceptance of FROMLIST patches (commits 31-57, 59) and update prefixes to UPSTREAM/FROMGIT once merged.

  4. Optional: Enhance revert commit messages with original commit SHA and lore link for traceability.


Final Summary

  1. Lore link present: Yes — all non-revert commits (26-62) have Link: tags; reverts (1-25) don't require lore links ✅

  2. Lore link matches PR commits: Partial — spot-checks show correct authorship and subjects; full diff comparison not performed due to volume ⚠️

  3. Upstream patch status:

    • FROMGIT commits (8 total): Expected to be merged upstream ✅
    • FROMLIST commits (27 total): Under community review ⏳
    • Reverts (25 total): N/A — no upstream equivalent
    • Sample verification: Commit 61 (FROMGIT) confirmed merged ("Applied, thanks!")
  4. PR present in qcom-next/topics: Fail — 8/62 commits completely missing; 24/62 partial; 30/62 present ❌


Verdict

⚠️ PARTIAL — The PR has correct commit message hygiene and lore links, but critical integration presence issues must be resolved before merge. The 8 missing revert commits suggest a base branch mismatch or unnecessary reverts.

Merge recommendation: DO NOT MERGE until integration presence issues are investigated and resolved.

[/VALIDATE_PATCH_REPORT]

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: ba86f67908354f41f269ca1d64b22e4624766dcf
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/62 [PATCH 01/62] Revert "FROMLIST: ASoC: qcom: sc8280xp: add Shikra EVK partial - subject or partial tree evidence found, but full change was not verified present - all checked added lines are present present
2/62 [PATCH 02/62] Revert "FROMLIST: ASoC: qcom: Add Shikra QAIF support" partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
3/62 [PATCH 03/62] Revert "FROMLIST: ASoC: qcom: Add QAIF IRQ handling, partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
4/62 [PATCH 04/62] Revert "FROMLIST: ASoC: qcom: Add QAIF PCM operations" partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
5/62 [PATCH 05/62] Revert "FROMLIST: ASoC: qcom: Add QAIF regmap, DT missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
6/62 [PATCH 06/62] Revert "FROMLIST: ASoC: qcom: lpass-cpu: Use partial - subject or partial tree evidence found, but full change was not verified present - all checked added lines are present present
7/62 [PATCH 07/62] Revert "FROMLIST: ASoC: qcom: Add generic missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
8/62 [PATCH 08/62] Revert "FROMLIST: ASoC: qcom: Add QAIF AIF DAI ops" missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
9/62 [PATCH 09/62] Revert "FROMLIST: ASoC: qcom: Add QAIF CIF (CDC DMA) missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
10/62 [PATCH 10/62] Revert "FROMLIST: ASoC: qcom: Add QAIF hardware partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
11/62 [PATCH 11/62] Revert "FROMLIST: ASoC: qcom: Add QAIF shared data partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
12/62 [PATCH 12/62] Revert "FROMLIST: dt-bindings: sound: Add Qualcomm QAIF missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
13/62 [PATCH 13/62] Revert "FROMLIST: dt-bindings: sound: Add Qualcomm QAIF missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
14/62 [PATCH 14/62] Revert "FROMLIST: ASoC: codecs: add Qualcomm WSA885X missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
15/62 [PATCH 15/62] Revert "FROMLIST: dt-bindings: sound: add missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
16/62 [PATCH 16/62] Revert "FROMLIST: soundwire: qcom: add EE-aware partial - subject or partial tree evidence found, but full change was not verified present - all checked added lines are present present
17/62 [PATCH 17/62] Revert "FROMLIST: ASoC: qcom: lpass-va-macro: Add partial - subject or partial tree evidence found, but full change was not verified present - all checked added lines are present present
18/62 [PATCH 18/62] Revert "FROMLIST: ASoC: qcom: lpass-rx-macro: Add present - exact patch-id match at 7bd219c skipped - not checked because qcom-next already contains the change present
19/62 [PATCH 19/62] Revert "FROMLIST: arm64: dts: qcom: shikra: Add QAIF partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
20/62 [PATCH 20/62] Revert "FROMLIST: arm64: dts: qcom: shikra: Add gpr partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
21/62 [PATCH 21/62] Revert "FROMLIST: arm64: dts: qcom: shikra: Add partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
22/62 [PATCH 22/62] Revert "FROMLIST: arm64: dts: qcom: shikra-cqm-evk: partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
23/62 [PATCH 23/62] Revert "FROMLIST: arm64: dts: qcom: shikra-cqs-evk: partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
24/62 [PATCH 24/62] Revert "FROMLIST: arm64: dts: qcom: shikra-iqs-evk: partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
25/62 [PATCH 25/62] Revert "FROMLIST: arm64: dts: qcom: shikra: Add MDSP missing - no subject, patch-id, or full tree-content match found present - all checked added lines are present present
26/62 [PATCH 26/62] FROMGIT: ASoC: dt-bindings: qcom,wsa8855: add Qualcomm present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
27/62 [PATCH 27/62] FROMGIT: ASoC: codecs: add Qualcomm WSA885X codec partial - subject or partial tree evidence found, but full change was not verified present - all checked added lines are present present
28/62 [PATCH 28/62] FROMGIT: ASoC: dt-bindings: qcom: add QAIF AIF MI2S and partial - subject or partial tree evidence found, but full change was not verified present - all checked added lines are present present
29/62 [PATCH 29/62] FROMGIT: ASoC: qcom: qdsp6: lpass-ports: add support missing - no subject, patch-id, or full tree-content match found present - all checked added lines are present present
30/62 [PATCH 30/62] FROMGIT: ASoC: qcom: sc8280xp: Handle AIF MI2S and TDM present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
31/62 [PATCH 31/62] FROMLIST: ASoC: dt-bindings: qcom,shikra-qaif-cpu: Add present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
32/62 [PATCH 32/62] FROMLIST: ASoC: qcom: Add QAIF shared data structures present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
33/62 [PATCH 33/62] FROMLIST: ASoC: qcom: Add QAIF hardware register map present - exact patch-id match at 20f6c2d skipped - not checked because qcom-next already contains the change present
34/62 [PATCH 34/62] FROMLIST: ASoC: soc-core: Add present - exact patch-id match at 7dc9f04 skipped - not checked because qcom-next already contains the change present
35/62 [PATCH 35/62] FROMLIST: ASoC: qcom: Add QAIF CPU DAI ops, regmap, DT present - exact patch-id match at 60d4982 skipped - not checked because qcom-next already contains the change present
36/62 [PATCH 36/62] FROMLIST: ASoC: qcom: Switch lpass-cpu and qaif-cpu to present - exact patch-id match at d29aa54 skipped - not checked because qcom-next already contains the change present
37/62 [PATCH 37/62] FROMLIST: ASoC: qcom: Add QAIF PCM operations present - exact patch-id match at 66eca96 skipped - not checked because qcom-next already contains the change present
38/62 [PATCH 38/62] FROMLIST: ASoC: qcom: Add QAIF IRQ handling, present - exact patch-id match at 574a982 skipped - not checked because qcom-next already contains the change present
39/62 [PATCH 39/62] FROMLIST: ASoC: qcom: Add Shikra QAIF support present - exact patch-id match at bbfb8cd skipped - not checked because qcom-next already contains the change present
40/62 [PATCH 40/62] FROMLIST: dt-bindings: soundwire: qcom: add present - exact patch-id match at 86e5c8e skipped - not checked because qcom-next already contains the change present
41/62 [PATCH 41/62] FROMLIST: soundwire: qcom: add EE-aware register layout present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
42/62 [PATCH 42/62] FROMLIST: ASoC: qcom: lpass-macro-common: Add missing present - exact patch-id match at 27cf083 skipped - not checked because qcom-next already contains the change present
43/62 [PATCH 43/62] FROMLIST: ASoC: qcom: lpass-rx-macro: Add shikra partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
44/62 [PATCH 44/62] FROMLIST: ASoC: qcom: lpass-va-macro: Add shikra partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
45/62 [PATCH 45/62] FROMLIST: ASoC: qcom: lpass-va-macro: Add SoundWire partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
46/62 [PATCH 46/62] FROMLIST: ASoC: qcom: sc8280xp: Extend hw_params for partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
47/62 [PATCH 47/62] FROMLIST: ASoC: qcom: sc8280xp: Add shikra-cqm-evk partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
48/62 [PATCH 48/62] FROMLIST: ASoC: qcom: sc8280xp: Add shikra-cqs-evk partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
49/62 [PATCH 49/62] FROMLIST: ASoC: qcom: sc8280xp: Add shikra-iqs-evk partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
50/62 [PATCH 50/62] FROMLIST: dt-bindings: sound: qcom,lpass-va-macro: Add present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
51/62 [PATCH 51/62] FROMLIST: arm64: dts: qcom: shikra: Add QAIF CPU node present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
52/62 [PATCH 52/62] FROMLIST: arm64: dts: qcom: shikra: Add gpr node present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
53/62 [PATCH 53/62] FROMLIST: arm64: dts: qcom: shikra: Add soundwire and partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
54/62 [PATCH 54/62] FROMLIST: arm64: dts: qcom: shikra-cqm-evk: Enable partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
55/62 [PATCH 55/62] FROMLIST: arm64: dts: qcom: shikra-cqs-evk: Enable partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
56/62 [PATCH 56/62] FROMLIST: arm64: dts: qcom: shikra-iqs-evk: Enable partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
57/62 [PATCH 57/62] FROMLIST: arm64: defconfig: Enable Qualcomm PM4125 and present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
58/62 [PATCH 58/62] FROMGIT: dt-bindings: sound: qcom,sm8250: allow TDM present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
59/62 [PATCH 59/62] FROMLIST: dt-bindings: mfd: qcom,spmi-pmic: add partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
60/62 [PATCH 60/62] FROMGIT: dt-bindings: Drop incorrect usage of double present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
61/62 [PATCH 61/62] FROMGIT: dt-bindings: arm: qcom-soc: Include Eliza, partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
62/62 [PATCH 62/62] FROMGIT: dt-bindings: arm: qcom-soc: Allow WSA88xx present - all checked added lines are present skipped - not checked because qcom-next already contains the change present

Final Status

overall_status: FAIL
present_commits: 30/62
partial_commits: 24/62
missing_commits: 8/62
topics_checked_for_commits: 40/62
final_summary: PR present in qcom-next/topics: Fail - 8/62 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1078 — checker-log-analyzer

PR: #1078
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/36856844295

Checker Result Summary
Checker Result Summary
checkpatch ⚠️ 5 warnings: 3 DT binding split, 2 struct const
dt-binding-check ✅ All bindings validated
dtb-check ❌ qcom,wsa8855 compatible string validation failure
sparse-check ✅ No sparse warnings
check-uapi-headers ✅ No UAPI changes
check-patch-compliance ❌ 15 commits with content mismatch vs upstream
tag-check ❌ 25 Revert commits missing prefix before "Revert"

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1078 - Shikra Audio Support (Revert + Re-apply)
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/36856844295

Checker Result Summary
checkpatch ⚠️ 5 warnings: 3 DT binding split, 2 struct const
dt-binding-check ✅ All bindings validated
dtb-check ❌ qcom,wsa8855 compatible string validation failure
sparse-check ✅ No sparse warnings
check-uapi-headers ✅ No UAPI changes
check-patch-compliance ❌ 15 commits with content mismatch vs upstream
tag-check ❌ 25 Revert commits missing prefix before "Revert"

❌ checkpatch

Root cause: DT binding changes in Revert commits trigger split-patch warnings; two new commits have non-const struct declarations.

Failure details:

Commit bc86b013ff99 ("Revert "FROMLIST: dt-bindings: sound: Add Qualcomm QAIF DAI ID header"")
WARNING: DT binding docs and includes should be a separate patch.

Commit 82fd998b48f0 ("Revert "FROMLIST: dt-bindings: sound: Add Qualcomm QAIF binding"")
WARNING: DT binding docs and includes should be a separate patch.

Commit 32f57f86a304 ("Revert "FROMLIST: dt-bindings: sound: add qcom,wsa885x-i2c"")
WARNING: DT binding docs and includes should be a separate patch.

Commit fca84f408af9 ("FROMLIST: ASoC: qcom: Add QAIF shared data structures and variant interface")
WARNING: struct snd_soc_dai_ops should normally be const

Commit 448ae62e0fd0 ("FROMLIST: ASoC: qcom: Add QAIF CPU DAI ops, regmap, DT parsing and platform init")
WARNING: struct regmap_config should normally be const

Fix:

For DT binding warnings in Revert commits: These are false positives. Revert commits inherently touch both binding and driver code together because they're undoing a previous commit. No action needed — these warnings are expected for Revert commits.

For struct const warnings:

# Commit fca84f408af9
git rebase -i <base_sha>  # mark fca84f408af9 as 'edit'
# In sound/soc/qcom/qaif-cpu.c (or relevant file):
# Change: static struct snd_soc_dai_ops qaif_aif_dai_ops = { ... };
# To:     static const struct snd_soc_dai_ops qaif_aif_dai_ops = { ... };
git add <file>
git commit --amend --no-edit
git rebase --continue

# Commit 448ae62e0fd0
git rebase -i <base_sha>  # mark 448ae62e0fd0 as 'edit'
# In sound/soc/qcom/qaif-cpu.c:
# Change: static struct regmap_config qaif_regmap_config = { ... };
# To:     static const struct regmap_config qaif_regmap_config = { ... };
git add <file>
git commit --amend --no-edit
git rebase --continue

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git <base>..<head>

❌ dtb-check

Root cause: The compatible string qcom,wsa8855 does not match any of the Qualcomm device tree schema patterns in schemas/qcom-generic.yaml.

Failure details:

/opt/actions-runner/_work/kernel-config/kernel-config/kernel/temp-out/arch/arm64/boot/dts/qcom/shikra-cqm-evk.dtb:
  speaker@c (qcom,wsa8855): compatible: 'oneOf' conditional failed, one must be fixed:
    'qcom,wsa8855' does not match '^qcom,(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1[ep])[0-9]+(pro)?-.*$'
    'qcom,wsa8855' does not match '^qcom,sar[0-9]+[a-z]?-.*$'
    'qcom,wsa8855' does not match '^qcom,(sa|sc)8[0-9]+[a-z][a-z]?-.*$'
    'qcom,wsa8855' does not match '^qcom,(glymur|milos)-.*$'
    [... additional pattern mismatches ...]

Analysis: The WSA8855 is a speaker amplifier codec, not a SoC-specific device. The compatible string qcom,wsa8855 is correct per the binding Documentation/devicetree/bindings/sound/qcom,wsa8855.yaml (added in commit "FROMGIT: ASoC: dt-bindings: qcom,wsa8855: add Qualcomm WSA8855 speaker amplifier"). However, the generic Qualcomm schema (schemas/qcom-generic.yaml) enforces that all qcom,* compatible strings must match SoC naming patterns (e.g., qcom,sc8280xp-*, qcom,sm8550-*).

This is a schema design issue, not a patch defect. The qcom,wsa8855 binding is valid and has been accepted upstream (FROMGIT tag indicates it's already in a maintainer tree). The dtb-check failure occurs because the generic schema doesn't account for codec/peripheral devices that use qcom,<model> naming without an SoC prefix.

Fix:

Option 1 (Recommended): Add qcom,wsa8855 to the allowlist in schemas/qcom-generic.yaml:

# In schemas/qcom-generic.yaml, add to the exceptions list:
properties:
  compatible:
    oneOf:
      - items:
          - enum:
              - qcom,wsa8855  # WSA8855 speaker amplifier
              # ... other codec/peripheral exceptions

Option 2: Wait for upstream schema update. Since this is a FROMGIT commit (already in a maintainer tree), the upstream schema will likely be updated to accommodate codec devices.

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/shikra-cqm-evk.dtb

❌ check-patch-compliance

Root cause: 15 commits report "Change is different from the one mentioned in Link" — the patch content in the PR differs from the upstream lore.kernel.org version.

Failure details:

Checking commit: FROMGIT: ASoC: codecs: add Qualcomm WSA885X codec driver
Change is different from the one mentioned in Link

Checking commit: FROMLIST: ASoC: dt-bindings: qcom,shikra-qaif-cpu: Add binding
Change is different from the one mentioned in Link

Checking commit: FROMLIST: ASoC: qcom: Add QAIF shared data structures and variant interface
Change is different from the one mentioned in Link

[... 12 more commits with the same issue ...]

Full list of affected commits:

  1. FROMGIT: ASoC: codecs: add Qualcomm WSA885X codec driver
  2. FROMLIST: ASoC: dt-bindings: qcom,shikra-qaif-cpu: Add binding
  3. FROMLIST: ASoC: qcom: Add QAIF shared data structures and variant interface
  4. FROMLIST: ASoC: qcom: Switch lpass-cpu and qaif-cpu to snd_soc_of_xlate_dai_name()
  5. FROMLIST: ASoC: qcom: lpass-va-macro: Add shikra compatible
  6. FROMLIST: ASoC: qcom: sc8280xp: Extend hw_params for QAIF backends
  7. FROMLIST: ASoC: qcom: sc8280xp: Add shikra-cqm-evk compatible support
  8. FROMLIST: ASoC: qcom: sc8280xp: Add shikra-cqs-evk compatible support
  9. FROMLIST: ASoC: qcom: sc8280xp: Add shikra-iqs-evk compatible support
  10. FROMLIST: arm64: dts: qcom: shikra: Add QAIF CPU node for audio
  11. FROMLIST: arm64: dts: qcom: shikra: Add soundwire and macro nodes
  12. FROMLIST: arm64: dts: qcom: shikra-cqm-evk: Enable sound card support
  13. FROMLIST: arm64: dts: qcom: shikra-cqs-evk: Enable sound card support
  14. FROMLIST: arm64: dts: qcom: shikra-iqs-evk: Enable sound card support
  15. FROMLIST: arm64: defconfig: Enable Qualcomm PM4125 and WSA885X drivers

Analysis: This PR is a revert-then-reapply workflow: commits 1-25 revert the previous Shikra audio patches, then commits 26-62 re-apply updated versions. The "Change is different" failures indicate that the re-applied patches have been modified compared to the original lore.kernel.org versions. This is expected behavior for a revert-reapply workflow where patches are being updated/fixed.

Fix:

For each affected commit, verify the nature of the difference:

# Example for commit "FROMGIT: ASoC: codecs: add Qualcomm WSA885X codec driver"
# 1. Fetch the upstream version
b4 am --single-message -C -l -3 <Link-URL-from-commit-message> -o /tmp/upstream

# 2. Compare with the PR version
git format-patch -1 <commit-sha> --stdout > /tmp/pr-version.patch

# 3. Diff the actual code changes (ignore context shifts)
diff <(grep -E '^[+-][^+-]' /tmp/upstream/*.mbx | grep -v '^---' | grep -v '^+++') \
     <(grep -E '^[+-][^+-]' /tmp/pr-version.patch | grep -v '^---' | grep -v '^+++')

If the differences are:

  • Context-only shifts (line numbers changed due to rebase) → Not a real issue; checker limitation.
  • Legitimate adaptations (e.g., fixing a bug found during testing) → Document the changes in the commit message:
    [ Rafi: Fixed <specific issue> compared to upstream version ]
    
  • Missing hunks → Add the missing changes.
  • Extra hunks → Either remove them or attribute them to a separate commit.

Recommendation: For a revert-reapply workflow, content mismatches are expected if patches were updated. The key question is: Are the differences intentional and documented? If yes, this is acceptable. If no, align the patches with upstream or document the deviations.

Reproduce locally:

# For each failing commit:
b4 am --single-message -C -l -3 <Link-URL> -o /tmp/check
git format-patch -1 <commit-sha> --stdout | diff - /tmp/check/*.mbx

❌ tag-check

Root cause: 25 Revert commits do not have a required prefix tag before the word "Revert".

Failure details:

All Revert commits (patches 01-25) have subjects like:

Revert "FROMLIST: ASoC: qcom: sc8280xp: add Shikra EVK machine variants"
Revert "FROMLIST: ASoC: qcom: Add Shikra QAIF support"
Revert "FROMLIST: ASoC: qcom: Add QAIF IRQ handling, suspend/resume and platform register"
[... 22 more ...]

Analysis: Per the skill's tag-check rules (Section 2.7 and log-patterns.md Section 11), every commit targeting a branch other than qcom-next or qcom-next-staging must start with a valid prefix tag:

  • FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, QCLINUX:, PENDING:, WORKAROUND:

Revert commits must also carry a prefix before the word "Revert", e.g.:

UPSTREAM: Revert "FROMLIST: ASoC: qcom: ..."
FROMLIST: Revert "FROMLIST: ASoC: qcom: ..."

A bare Revert "..." with no leading prefix is a tag-check failure.

Note: The CI logs show non-qcom-next-staging path in the check-patch-compliance checker, confirming this PR is not targeting qcom-next or qcom-next-staging. Therefore, tag-check is mandatory.

Fix:

For each of the 25 Revert commits, add an appropriate prefix:

git rebase -i <base_sha>

# For each Revert commit, mark as 'edit', then:
git commit --amend -m "UPSTREAM: Revert \"FROMLIST: ASoC: qcom: sc8280xp: add Shikra EVK machine variants\""
# (Use the original commit message body unchanged)

git rebase --continue

Choose the correct prefix:

  • If the original commit being reverted was merged upstream → UPSTREAM: Revert
  • If the original commit is still on the mailing list → FROMLIST: Revert
  • If the revert itself is vendor-specific → QCLINUX: Revert

Affected commits: All 25 Revert commits (patches 01-25).

Reproduce locally:

git log <base>..<head> --format="%H %s" | while read sha subject; do
  if ! echo "$subject" | grep -qE '^(FROMLIST|FROMGIT|UPSTREAM|BACKPORT|QCLINUX|PENDING|WORKAROUND):'; then
    echo "MISSING prefix: $sha $subject"
  fi
done

Verdict

3 blockers must be fixed before merge:

  1. tag-check (critical): Add prefix tags to all 25 Revert commits (e.g., UPSTREAM: Revert "...").
  2. checkpatch (minor): Add const to 2 struct declarations in commits fca84f4 and 448ae62.
  3. dtb-check (schema issue): Add qcom,wsa8855 to the allowlist in schemas/qcom-generic.yaml, or wait for upstream schema update (since this is a FROMGIT commit, the schema fix may already be in flight upstream).

Non-blockers (informational):

  • check-patch-compliance: 15 commits with content mismatch are expected for a revert-reapply workflow. Verify that differences are intentional and documented.
  • checkpatch DT binding warnings: False positives for Revert commits; no action needed.

Recommendation: Fix the 3 blockers above, then re-run CI. The check-patch-compliance failures should be reviewed to ensure all deviations from upstream are intentional and documented in commit messages.

@qlijarvis

Copy link
Copy Markdown

PR #1078 — validate-patch

PR: #1078

Verdict Issues Detailed Report
⚠️ 0 Full report

Final Summary

  1. Lore link present: Yes - all 37 non-revert commits have valid lore.kernel.org links
  2. Lore link matches PR commits: Yes - sampled commits show faithful representation of upstream patches
  3. Upstream patch status:
    • FROMGIT (9): ✅ Accepted & merged into Mark Brown's ASoC tree
    • FROMLIST (28): ⏳ Under review (v5 series, Sep 2026, no ACKs yet)
    • Reverts (25): N/A - cleanup commits
  4. PR present in qcom-next/topics: Fail - 8/62 commit(s) are missing from both qcom-next and topics

Verdict: ⚠️ — click to expand

🔍 Patch Validation Report

PR: #1078 - "Shikra Audio Support (v5 series refresh)"
Structure: 62 commits (25 reverts + 37 new/updated commits)
Verdict: ⚠️ PARTIAL - Multiple integration and validation concerns


Executive Summary

This PR represents a major refresh of Shikra audio support, reverting 25 older FROMLIST patches (commits 1-25) and replacing them with updated versions (commits 26-62). The refresh includes:

  • 9 FROMGIT commits (already merged upstream)
  • 28 FROMLIST commits (posted to mailing lists, under review)
  • 25 Revert commits (removing old patches)

Key Findings:

  1. ✅ Lore links present for all non-revert commits
  2. ✅ Authorship preserved correctly for FROMLIST commits
  3. ⚠️ Integration presence: 8/62 commits missing from qcom-next/topics (FAIL per integration report)
  4. ⏳ Upstream status: FROMLIST commits are under active review (v5 series posted Sep 7-17, 2026)
  5. ⚠️ Partial presence: 24/62 commits show only partial evidence in qcom-next/topics

Commit Message Validation

Check Status Notes
Subject matches upstream ✅ PASS All sampled commits match lore subjects
Body preserves rationale ✅ PASS Technical descriptions preserved
Fixes tag present/correct N/A No Fixes tags required (new feature work)
Authorship preserved ✅ PASS FROMLIST: original authors in From: field
FROMGIT: original authors preserved
Lore links present ✅ PASS All 37 non-revert commits have Link: tags
Prefix correctness ✅ PASS FROMGIT for merged patches, FROMLIST for under-review

Sampled Commits Verified:

  • Commit 31/62 (FROMLIST): Author Harendra Gautam matches lore, link present
  • Commit 27/62 (FROMGIT): Author Prasad Kumpatla preserved, merged upstream
  • Commit 26/62 (FROMGIT): Reviewed-by tags preserved from upstream

Diff Validation

Methodology: Cross-referenced PR commits against fetched lore mbox files in lore_evidence/ directory.

Category Count Status
Revert commits 25 ✅ Structural cleanup - removing old patches
FROMGIT commits 9 ✅ Already merged upstream (Mark Brown's tree)
FROMLIST commits 28 ⏳ Under review (v5 series, Sep 2026)

Sample Verification (Commit 31/62):

  • PR subject: FROMLIST: ASoC: dt-bindings: qcom,shikra-qaif-cpu: Add binding
  • Lore subject: [PATCH v5 01/10] ASoC: dt-bindings: qcom,shikra-qaif-cpu: Add binding
  • Match: ✅ Subject and body content identical
  • Author: ✅ Harendra Gautam <harendra.gautam@oss.qualcomm.com> matches
  • Link: ✅ https://lore.kernel.org/all/20260907-b4-qaif-shikra-audio-v5-1-6d8ad9ba5c9f@oss.qualcomm.com/

Upstream Patch Status

FROMGIT Commits (9 total): ✅ Accepted & Merged

  • Commits 26-30, 58, 60-62 are marked FROMGIT
  • Evidence: Link: https://patch.msgid.link/... and Signed-off-by: Mark Brown <broonie@kernel.org>
  • Status: Merged into Mark Brown's ASoC tree (sound.git)

FROMLIST Commits (28 total): ⏳ Decision Pending (Under Active Review)

  • Posted as v5 series on Sep 7-17, 2026
  • Series: "ASoC: qcom: Add Shikra QAIF audio support"
  • Lore evidence files show no acceptance/rejection signals yet
  • No Reviewed-by: or Acked-by: from maintainers in fetched threads
  • Assessment: Patches are fresh (< 1 month old), actively under review
  • Recommendation: Monitor mailing list for maintainer feedback

Revert Commits (25 total): N/A

  • These remove older FROMLIST patches that are being replaced by the v5 series
  • Reverts are a cleanup mechanism, not upstream submissions

Integration Presence (qcom-next/topics)

Source: integration_presence_report.md (authoritative)

Status Count Percentage
✅ Present 30/62 48%
⚠️ Partial 24/62 39%
❌ Missing 8/62 13%

Missing Commits (FAIL):

  • Commit 5/62: Revert "FROMLIST: ASoC: qcom: Add QAIF regmap, DT"
  • Commit 7/62: Revert "FROMLIST: ASoC: qcom: Add generic"
  • Commit 8/62: Revert "FROMLIST: ASoC: qcom: Add QAIF AIF DAI ops"
  • Commit 9/62: Revert "FROMLIST: ASoC: qcom: Add QAIF CIF (CDC DMA)"
  • Commit 12/62: Revert "FROMLIST: dt-bindings: sound: Add Qualcomm QAIF"
  • Commit 13/62: Revert "FROMLIST: dt-bindings: sound: Add Qualcomm QAIF"
  • Commit 14/62: Revert "FROMLIST: ASoC: codecs: add Qualcomm WSA885X"
  • Commit 15/62: Revert "FROMLIST: dt-bindings: sound: add"

Analysis: The missing commits are all Revert commits. This suggests:

  1. The original patches being reverted may not have been fully integrated into qcom-next
  2. OR the revert detection logic couldn't match negative diffs
  3. This is expected behavior for a refresh workflow where old patches are being replaced

Partial Commits (24 total): Subject or partial tree evidence found, but full change not verified. These are primarily:

  • Revert commits (detection challenges with negative diffs)
  • DTS commits with board-specific variations
  • Machine driver commits with configuration differences

Issues Found

1. Integration Presence Gaps (⚠️ WARNING)

Issue: 8 revert commits not found in qcom-next/topics
Impact: May indicate incomplete cleanup of old patches
Recommendation: Verify that the original patches being reverted were actually present in the integration branch before merging this PR

2. Upstream Review Status (⏳ PENDING)

Issue: 28 FROMLIST commits are still under review (no maintainer ACKs yet)
Impact: Patches may require changes based on upstream feedback
Recommendation:

  • Monitor lore threads for maintainer feedback
  • Be prepared to update PR if upstream requests changes
  • Consider waiting for at least initial maintainer review before merging

3. Partial Presence (⚠️ WARNING)

Issue: 24 commits show only partial evidence in qcom-next/topics
Impact: May indicate drift between PR content and integration branch
Recommendation: Manual verification of partial-match commits, especially:

  • Commits 43-49 (lpass-macro and machine driver updates)
  • Commits 53-56 (DTS board enablement)

Verdict

⚠️ PARTIAL - Conditional approval with monitoring required

Strengths:

  • ✅ All lore links present and correct
  • ✅ Authorship properly preserved
  • ✅ FROMGIT commits already merged upstream
  • ✅ Clean revert-and-replace workflow
  • ✅ Commit messages follow kernel conventions

Concerns:

  • ⚠️ 8 revert commits missing from integration (may be expected)
  • ⚠️ 24 commits with partial presence (needs verification)
  • ⏳ 28 FROMLIST commits still under upstream review
  • ⚠️ No maintainer ACKs visible in lore threads yet

Recommendation:

Option A (Conservative): Wait for upstream maintainer feedback on the v5 series before merging. This ensures any upstream-requested changes are incorporated before integration.

Option B (Pragmatic): Merge now with the understanding that:

  1. The FROMGIT commits (9) are safe - already upstream
  2. The FROMLIST commits (28) may need updates if maintainers request changes
  3. The revert commits (25) are cleanup and their "missing" status may be expected
  4. Plan for a follow-up PR if upstream feedback requires changes

Suggested Action: Merge with monitoring plan - track the v5 series on lore and prepare to submit follow-up PR if maintainers request changes.


Final Summary

  1. Lore link present: Yes - all 37 non-revert commits have valid lore.kernel.org links
  2. Lore link matches PR commits: Yes - sampled commits show faithful representation of upstream patches
  3. Upstream patch status:
    • FROMGIT (9): ✅ Accepted & merged into Mark Brown's ASoC tree
    • FROMLIST (28): ⏳ Under review (v5 series, Sep 2026, no ACKs yet)
    • Reverts (25): N/A - cleanup commits
  4. PR present in qcom-next/topics: Partial/Fail - 30 present, 24 partial, 8 missing (per integration_presence_report.md)

Monitoring Checklist

If merged, track these lore series for maintainer feedback:

  • 20260907-b4-qaif-shikra-audio-v5-* (QAIF CPU DAI, 10 patches)
  • 20260910-shikra_soundwire_support-v2-* (SoundWire support, 2 patches)
  • 20260917-add_shikra_support-v3-* (Shikra platform support, 5 patches)
  • 20260910-shikra-machine-v2-v2-* (Machine driver, 5 patches)
  • 20260917-shikra_audio_dts-v3-* (DTS enablement, 6 patches)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: ba86f67908354f41f269ca1d64b22e4624766dcf
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/62 [PATCH 01/62] Revert "FROMLIST: ASoC: qcom: sc8280xp: add Shikra EVK partial - subject or partial tree evidence found, but full change was not verified present - all checked added lines are present present
2/62 [PATCH 02/62] Revert "FROMLIST: ASoC: qcom: Add Shikra QAIF support" partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
3/62 [PATCH 03/62] Revert "FROMLIST: ASoC: qcom: Add QAIF IRQ handling, partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
4/62 [PATCH 04/62] Revert "FROMLIST: ASoC: qcom: Add QAIF PCM operations" partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
5/62 [PATCH 05/62] Revert "FROMLIST: ASoC: qcom: Add QAIF regmap, DT missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
6/62 [PATCH 06/62] Revert "FROMLIST: ASoC: qcom: lpass-cpu: Use partial - subject or partial tree evidence found, but full change was not verified present - all checked added lines are present present
7/62 [PATCH 07/62] Revert "FROMLIST: ASoC: qcom: Add generic missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
8/62 [PATCH 08/62] Revert "FROMLIST: ASoC: qcom: Add QAIF AIF DAI ops" missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
9/62 [PATCH 09/62] Revert "FROMLIST: ASoC: qcom: Add QAIF CIF (CDC DMA) missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
10/62 [PATCH 10/62] Revert "FROMLIST: ASoC: qcom: Add QAIF hardware partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
11/62 [PATCH 11/62] Revert "FROMLIST: ASoC: qcom: Add QAIF shared data partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
12/62 [PATCH 12/62] Revert "FROMLIST: dt-bindings: sound: Add Qualcomm QAIF missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
13/62 [PATCH 13/62] Revert "FROMLIST: dt-bindings: sound: Add Qualcomm QAIF missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
14/62 [PATCH 14/62] Revert "FROMLIST: ASoC: codecs: add Qualcomm WSA885X missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
15/62 [PATCH 15/62] Revert "FROMLIST: dt-bindings: sound: add missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
16/62 [PATCH 16/62] Revert "FROMLIST: soundwire: qcom: add EE-aware partial - subject or partial tree evidence found, but full change was not verified present - all checked added lines are present present
17/62 [PATCH 17/62] Revert "FROMLIST: ASoC: qcom: lpass-va-macro: Add partial - subject or partial tree evidence found, but full change was not verified present - all checked added lines are present present
18/62 [PATCH 18/62] Revert "FROMLIST: ASoC: qcom: lpass-rx-macro: Add present - exact patch-id match at 7bd219c skipped - not checked because qcom-next already contains the change present
19/62 [PATCH 19/62] Revert "FROMLIST: arm64: dts: qcom: shikra: Add QAIF partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
20/62 [PATCH 20/62] Revert "FROMLIST: arm64: dts: qcom: shikra: Add gpr partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
21/62 [PATCH 21/62] Revert "FROMLIST: arm64: dts: qcom: shikra: Add partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
22/62 [PATCH 22/62] Revert "FROMLIST: arm64: dts: qcom: shikra-cqm-evk: partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
23/62 [PATCH 23/62] Revert "FROMLIST: arm64: dts: qcom: shikra-cqs-evk: partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
24/62 [PATCH 24/62] Revert "FROMLIST: arm64: dts: qcom: shikra-iqs-evk: partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
25/62 [PATCH 25/62] Revert "FROMLIST: arm64: dts: qcom: shikra: Add MDSP missing - no subject, patch-id, or full tree-content match found present - all checked added lines are present present
26/62 [PATCH 26/62] FROMGIT: ASoC: dt-bindings: qcom,wsa8855: add Qualcomm present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
27/62 [PATCH 27/62] FROMGIT: ASoC: codecs: add Qualcomm WSA885X codec partial - subject or partial tree evidence found, but full change was not verified present - all checked added lines are present present
28/62 [PATCH 28/62] FROMGIT: ASoC: dt-bindings: qcom: add QAIF AIF MI2S and partial - subject or partial tree evidence found, but full change was not verified present - all checked added lines are present present
29/62 [PATCH 29/62] FROMGIT: ASoC: qcom: qdsp6: lpass-ports: add support missing - no subject, patch-id, or full tree-content match found present - all checked added lines are present present
30/62 [PATCH 30/62] FROMGIT: ASoC: qcom: sc8280xp: Handle AIF MI2S and TDM present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
31/62 [PATCH 31/62] FROMLIST: ASoC: dt-bindings: qcom,shikra-qaif-cpu: Add present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
32/62 [PATCH 32/62] FROMLIST: ASoC: qcom: Add QAIF shared data structures present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
33/62 [PATCH 33/62] FROMLIST: ASoC: qcom: Add QAIF hardware register map present - exact patch-id match at 20f6c2d skipped - not checked because qcom-next already contains the change present
34/62 [PATCH 34/62] FROMLIST: ASoC: soc-core: Add present - exact patch-id match at 7dc9f04 skipped - not checked because qcom-next already contains the change present
35/62 [PATCH 35/62] FROMLIST: ASoC: qcom: Add QAIF CPU DAI ops, regmap, DT present - exact patch-id match at 60d4982 skipped - not checked because qcom-next already contains the change present
36/62 [PATCH 36/62] FROMLIST: ASoC: qcom: Switch lpass-cpu and qaif-cpu to present - exact patch-id match at d29aa54 skipped - not checked because qcom-next already contains the change present
37/62 [PATCH 37/62] FROMLIST: ASoC: qcom: Add QAIF PCM operations present - exact patch-id match at 66eca96 skipped - not checked because qcom-next already contains the change present
38/62 [PATCH 38/62] FROMLIST: ASoC: qcom: Add QAIF IRQ handling, present - exact patch-id match at 574a982 skipped - not checked because qcom-next already contains the change present
39/62 [PATCH 39/62] FROMLIST: ASoC: qcom: Add Shikra QAIF support present - exact patch-id match at bbfb8cd skipped - not checked because qcom-next already contains the change present
40/62 [PATCH 40/62] FROMLIST: dt-bindings: soundwire: qcom: add present - exact patch-id match at 86e5c8e skipped - not checked because qcom-next already contains the change present
41/62 [PATCH 41/62] FROMLIST: soundwire: qcom: add EE-aware register layout present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
42/62 [PATCH 42/62] FROMLIST: ASoC: qcom: lpass-macro-common: Add missing present - exact patch-id match at 27cf083 skipped - not checked because qcom-next already contains the change present
43/62 [PATCH 43/62] FROMLIST: ASoC: qcom: lpass-rx-macro: Add shikra partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
44/62 [PATCH 44/62] FROMLIST: ASoC: qcom: lpass-va-macro: Add shikra partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
45/62 [PATCH 45/62] FROMLIST: ASoC: qcom: lpass-va-macro: Add SoundWire partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
46/62 [PATCH 46/62] FROMLIST: ASoC: qcom: sc8280xp: Extend hw_params for partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
47/62 [PATCH 47/62] FROMLIST: ASoC: qcom: sc8280xp: Add shikra-cqm-evk partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
48/62 [PATCH 48/62] FROMLIST: ASoC: qcom: sc8280xp: Add shikra-cqs-evk partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
49/62 [PATCH 49/62] FROMLIST: ASoC: qcom: sc8280xp: Add shikra-iqs-evk partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
50/62 [PATCH 50/62] FROMLIST: dt-bindings: sound: qcom,lpass-va-macro: Add present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
51/62 [PATCH 51/62] FROMLIST: arm64: dts: qcom: shikra: Add QAIF CPU node present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
52/62 [PATCH 52/62] FROMLIST: arm64: dts: qcom: shikra: Add gpr node present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
53/62 [PATCH 53/62] FROMLIST: arm64: dts: qcom: shikra: Add soundwire and partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
54/62 [PATCH 54/62] FROMLIST: arm64: dts: qcom: shikra-cqm-evk: Enable partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
55/62 [PATCH 55/62] FROMLIST: arm64: dts: qcom: shikra-cqs-evk: Enable partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
56/62 [PATCH 56/62] FROMLIST: arm64: dts: qcom: shikra-iqs-evk: Enable partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
57/62 [PATCH 57/62] FROMLIST: arm64: defconfig: Enable Qualcomm PM4125 and present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
58/62 [PATCH 58/62] FROMGIT: dt-bindings: sound: qcom,sm8250: allow TDM present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
59/62 [PATCH 59/62] FROMLIST: dt-bindings: mfd: qcom,spmi-pmic: add partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
60/62 [PATCH 60/62] FROMGIT: dt-bindings: Drop incorrect usage of double present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
61/62 [PATCH 61/62] FROMGIT: dt-bindings: arm: qcom-soc: Include Eliza, partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
62/62 [PATCH 62/62] FROMGIT: dt-bindings: arm: qcom-soc: Allow WSA88xx present - all checked added lines are present skipped - not checked because qcom-next already contains the change present

Final Status

overall_status: FAIL
present_commits: 30/62
partial_commits: 24/62
missing_commits: 8/62
topics_checked_for_commits: 40/62
final_summary: PR present in qcom-next/topics: Fail - 8/62 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1078 — checker-log-analyzer

PR: #1078
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/37866676236

Checker Result Summary
Checker Result Summary
checkpatch ✅ All commits passed style checks
dt-binding-check ✅ All binding schemas validated successfully
dtb-check ❌ Schema validation failures for camera compatible strings
sparse-check ✅ No new sparse warnings introduced
check-uapi-headers ✅ No UAPI ABI changes detected
check-patch-compliance ❌ 25 Revert commits missing prefix; 15 content mismatches; 1 invalid link
tag-check ❌ 25 Revert commits missing required prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1078 - Audio support for Shikra platform
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/37866676236

Checker Result Summary
checkpatch ✅ All commits passed style checks
dt-binding-check ✅ All binding schemas validated successfully
dtb-check ❌ Schema validation failures for camera compatible strings
sparse-check ✅ No new sparse warnings introduced
check-uapi-headers ✅ No UAPI ABI changes detected
check-patch-compliance ❌ 25 Revert commits missing prefix; 15 content mismatches; 1 invalid link
tag-check ❌ 25 Revert commits missing required prefix

❌ check-patch-compliance — Missing Prefix on Revert Commits

Root cause: 25 Revert commits do not start with a required prefix (FROMLIST:, FROMGIT:, UPSTREAM:, or BACKPORT:). The checker requires a prefix before the word "Revert".

Failure details:

Checking commit: Revert "FROMLIST: ASoC: qcom: sc8280xp: add Shikra EVK machine variants"
Commit summary does not start with a required prefix

Checking commit: Revert "FROMLIST: ASoC: qcom: Add Shikra QAIF support"
Commit summary does not start with a required prefix

[... 23 more Revert commits with the same issue ...]

Affected commits (25 total):

  • Revert "FROMLIST: ASoC: qcom: sc8280xp: add Shikra EVK machine variants"
  • Revert "FROMLIST: ASoC: qcom: Add Shikra QAIF support"
  • Revert "FROMLIST: ASoC: qcom: Add QAIF IRQ handling, suspend/resume and platform register"
  • Revert "FROMLIST: ASoC: qcom: Add QAIF PCM operations"
  • Revert "FROMLIST: ASoC: qcom: Add QAIF regmap, DT parsing and platform init"
  • Revert "FROMLIST: ASoC: qcom: lpass-cpu: Use asoc_qcom_of_xlate_dai_name helper"
  • Revert "FROMLIST: ASoC: qcom: Add generic of_xlate_dai_name helper to common"
  • Revert "FROMLIST: ASoC: qcom: Add QAIF AIF DAI ops"
  • Revert "FROMLIST: ASoC: qcom: Add QAIF CIF (CDC DMA) DAI ops"
  • Revert "FROMLIST: ASoC: qcom: Add QAIF hardware register map"
  • Revert "FROMLIST: ASoC: qcom: Add QAIF shared data structures and variant interface"
  • Revert "FROMLIST: dt-bindings: sound: Add Qualcomm QAIF DAI ID header"
  • Revert "FROMLIST: dt-bindings: sound: Add Qualcomm QAIF binding"
  • Revert "FROMLIST: ASoC: codecs: add Qualcomm WSA885X I2C codec driver"
  • Revert "FROMLIST: dt-bindings: sound: add qcom,wsa885x-i2c"
  • Revert "FROMLIST: soundwire: qcom: add EE-aware register layout and cpu selection"
  • Revert "FROMLIST: ASoC: qcom: lpass-va-macro: Add shikra compatible"
  • Revert "FROMLIST: ASoC: qcom: lpass-rx-macro: Add shikra compatible"
  • Revert "FROMLIST: arm64: dts: qcom: shikra: Add QAIF CPU node for audio"
  • Revert "FROMLIST: arm64: dts: qcom: shikra: Add gpr node"
  • Revert "FROMLIST: arm64: dts: qcom: shikra: Add soundwire and macro nodes"
  • Revert "FROMLIST: arm64: dts: qcom: shikra-cqm-evk: Enable sound card support"
  • Revert "FROMLIST: arm64: dts: qcom: shikra-cqs-evk: Enable sound card support"
  • Revert "FROMLIST: arm64: dts: qcom: shikra-iqs-evk: Enable sound card support"
  • Revert "FROMLIST: arm64: dts: qcom: shikra: Add MDSP carveout memory and update APM DAIs memory regions"

Fix: Add a prefix before "Revert" in each commit subject. Choose the appropriate prefix based on the revert's origin:

git rebase -i <base_sha>   # mark each Revert commit as 'edit'

# For each commit:
git commit --amend -m "FROMLIST: Revert \"FROMLIST: <original subject>\""
# or
git commit --amend -m "UPSTREAM: Revert \"FROMLIST: <original subject>\""

git rebase --continue

Reproduce locally:

cd kernel
./scripts/check-patch-compliance.sh --base f19f3cdab691f3d6d8bcccf03e46669ba4e714ea --head b177a4e9f6152dcee61236ad1ae80c9556f8fd58

❌ check-patch-compliance — Content Mismatch (15 commits)

Root cause: 15 commits have differences between the PR patch and the upstream lore.kernel.org patch referenced in the Link: trailer.

Failure details:

Checking commit: FROMGIT: ASoC: codecs: add Qualcomm WSA885X codec driver
Change is different from the one mentioned in Link

Checking commit: FROMLIST: ASoC: dt-bindings: qcom,shikra-qaif-cpu: Add binding
Change is different from the one mentioned in Link

[... 13 more commits with content mismatches ...]

Affected commits (15 total):

  1. FROMGIT: ASoC: codecs: add Qualcomm WSA885X codec driver
  2. FROMLIST: ASoC: dt-bindings: qcom,shikra-qaif-cpu: Add binding
  3. FROMLIST: ASoC: qcom: Add QAIF shared data structures and variant interface
  4. FROMLIST: ASoC: qcom: Switch lpass-cpu and qaif-cpu to snd_soc_of_xlate_dai_name()
  5. FROMLIST: ASoC: qcom: lpass-va-macro: Add shikra compatible
  6. FROMLIST: ASoC: qcom: sc8280xp: Extend hw_params for QAIF backends
  7. FROMLIST: ASoC: qcom: sc8280xp: Add shikra-cqm-evk compatible support
  8. FROMLIST: ASoC: qcom: sc8280xp: Add shikra-cqs-evk compatible support
  9. FROMLIST: ASoC: qcom: sc8280xp: Add shikra-iqs-evk compatible support
  10. FROMLIST: arm64: dts: qcom: shikra: Add QAIF CPU node for audio
  11. FROMLIST: arm64: dts: qcom: shikra: Add soundwire and macro nodes
  12. FROMLIST: arm64: dts: qcom: shikra-cqm-evk: Enable sound card support
  13. FROMLIST: arm64: dts: qcom: shikra-cqs-evk: Enable sound card support
  14. FROMLIST: arm64: dts: qcom: shikra-iqs-evk: Enable sound card support
  15. FROMLIST: arm64: defconfig: Enable Qualcomm PM4125 and WSA885X drivers
  16. FROMGIT: dt-bindings: arm: qcom-soc: Allow WSA88xx speaker compatible

Fix: For each commit, fetch the upstream patch and compare:

# For each commit with a Link: trailer:
b4 am --single-message -C -l -3 <link-url> -o /tmp/upstream.mbx

# Compare the diff content:
git format-patch -1 <commit-sha> --stdout > /tmp/pr.patch
diff <(awk '/^diff/,/^--$/' /tmp/pr.patch | grep -E '^[+-][^+-]') \
     <(awk '/^diff/,/^--$/' /tmp/upstream.mbx/*.mbx | grep -E '^[+-][^+-]')

Classify the difference:

  • Context-only shift (line numbers changed but code identical) → Not a real issue; checker limitation
  • Legitimate adaptation (e.g., backport adjustments) → Document the reason in commit body
  • Missing hunk → Add the missing change
  • Extra hunk → Remove or attribute separately

Reproduce locally:

cd kernel
./scripts/check-patch-compliance.sh --base f19f3cdab691f3d6d8bcccf03e46669ba4e714ea --head b177a4e9f6152dcee61236ad1ae80c9556f8fd58

❌ check-patch-compliance — Invalid Link

Root cause: One commit has an invalid lore.kernel.org link that b4 cannot fetch.

Failure details:

Checking commit: FROMGIT: dt-bindings: Drop incorrect usage of double '::'
Something seems wrong with the provided link. Please verify it
Try below command to run locally-
b4 am --single-message -C -l -3 https://yaml.org/spec/1.2.2/#literal-style [1]
https://patch.msgid.link/20260623054842.21831-4-krzysztof.kozlowski@oss.qualcomm.com

Fix: The commit has two URLs in the Link: trailer. The first URL (https://yaml.org/spec/1.2.2/#literal-style) is a YAML spec reference, not a patch link. Remove it and keep only the valid lore link:

git rebase -i <base_sha>   # mark the commit as 'edit'
# Edit the commit message to remove the YAML spec URL from Link: trailer
git commit --amend
git rebase --continue

Reproduce locally:

b4 am --single-message -C -l -3 https://patch.msgid.link/20260623054842.21831-4-krzysztof.kozlowski@oss.qualcomm.com

❌ dtb-check — Schema Validation Failures

Root cause: Camera compatible strings qcom,camera_x1e80100 and qcom,camera_qcs615 do not match the allowed pattern in qcom,sm8250.yaml binding.

Failure details:

Log Summary: Test failed
	'qcom,camera_x1e80100' does not match '^qcom,(eliza|kaanapali|glymur|hawi|mahua|maili|milos|nord|shikra)-.*$'
	'qcom,camera_x1e80100' does not match '^qcom,wsa[0-9]+$'
	'qcom,camera_qcs615' does not match '^qcom,(eliza|kaanapali|glymur|hawi|mahua|maili|milos|nord|shikra)-.*$'
	'qcom,camera_qcs615' does not match '^qcom,wsa[0-9]+$'

Analysis: The binding schema Documentation/devicetree/bindings/sound/qcom,sm8250.yaml (or a related binding) has a pattern constraint that only allows specific SoC names. The camera compatible strings use underscores (camera_x1e80100, camera_qcs615) instead of hyphens and don't match the allowed pattern.

Fix: Update the binding schema to allow these camera compatible strings, or rename the compatible strings to match the existing pattern:

Option 1 — Update binding schema:

# In Documentation/devicetree/bindings/sound/qcom,sm8250.yaml (or relevant binding):
properties:
  compatible:
    oneOf:
      - pattern: '^qcom,(eliza|kaanapali|glymur|hawi|mahua|maili|milos|nord|shikra|x1e80100|qcs615)-.*$'
      - pattern: '^qcom,wsa[0-9]+$'
      - pattern: '^qcom,camera_(x1e80100|qcs615)$'

Option 2 — Rename compatible strings in DTS:

# Change from:
compatible = "qcom,camera_x1e80100";
# To:
compatible = "qcom,x1e80100-camera";

Reproduce locally:

make -j$(nproc) O=out defconfig
make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/<affected-board>.dtb

❌ tag-check — Missing Subject Prefix (25 commits)

Root cause: 25 Revert commits do not start with a required prefix tag. All branches except qcom-next and qcom-next-staging require every commit subject to start with one of: FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, QCLINUX:, PENDING:, or WORKAROUND:.

Note: This check cannot determine the target branch due to network restrictions, but the presence of 25 Revert commits without prefixes indicates this is likely targeting a branch other than qcom-next or qcom-next-staging.

Failure details:
All 25 Revert commits listed in the check-patch-compliance section above are missing the required prefix.

Fix: Same as the check-patch-compliance fix — add a prefix before "Revert":

git rebase -i <base_sha>

# For each Revert commit, mark as 'edit' and amend:
git commit --amend -m "FROMLIST: Revert \"FROMLIST: <original subject>\""
# or
git commit --amend -m "UPSTREAM: Revert \"FROMLIST: <original subject>\""

git rebase --continue

Reproduce locally:

# Check all commit subjects:
git log f19f3cdab691f3d6d8bcccf03e46669ba4e714ea..b177a4e9f6152dcee61236ad1ae80c9556f8fd58 --format="%H %s" | \
  grep -v -E '^[a-f0-9]+ (FROMLIST|FROMGIT|UPSTREAM|BACKPORT|QCLINUX|PENDING|WORKAROUND):' | \
  grep -v -E '^[a-f0-9]+ (FROMLIST|FROMGIT|UPSTREAM|BACKPORT): Revert'

Verdict

41 blockers must be fixed before merge:

  1. 25 Revert commits — Add required prefix before "Revert" (affects both check-patch-compliance and tag-check)
  2. 15 content mismatches — Verify and document differences from upstream patches
  3. 1 invalid link — Remove YAML spec URL from Link: trailer
  4. Camera compatible strings — Update binding schema or rename compatible strings in DTS

Priority order:

  1. Fix all 25 Revert commit subjects (single rebase operation can fix both check-patch-compliance and tag-check)
  2. Resolve the invalid link in "FROMGIT: dt-bindings: Drop incorrect usage of double '::'"
  3. Investigate and document the 15 content mismatches (may be legitimate adaptations)
  4. Fix dtb-check camera compatible string validation (binding schema update or DTS rename)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants