Skip to content

gh-159606: Skip test_faulthandler signal tests on ASan - #159607

Closed
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:test_faulthandler_asan
Closed

vstinner wants to merge 1 commit into
python:mainfrom
vstinner:test_faulthandler_asan

Conversation

@vstinner

@vstinner vstinner commented Oct 17, 2026 •

Copy link
Copy Markdown
Member

The address sanitizer can catch signals such as SIGBUG and then hangs.

The address sanitizer can catch signals such as SIGBUG and then
hangs.
@vstinner

Copy link
Copy Markdown
Member Author

!buildbot x86-64 MacOS Intel ASAN NoGIL PR

@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @vstinner for commit 6f18149 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F159607%2Fmerge

The command will test the builders whose names match following regular expression: x86-64 MacOS Intel ASAN NoGIL PR

The builders matched are:

  • x86-64 MacOS Intel ASAN NoGIL PR

@vstinner

Copy link
Copy Markdown
Member Author

I'm not sure why test_sigbus() hangs on "x86-64 MacOS Intel ASAN NoGIL 3.x". Since we already skip signal tests on TSan/UBSan/MSan, I think that it should be fine to also skip them on ASan.

cc @StanFromIreland

@vstinner

Copy link
Copy Markdown
Member Author

Maybe the problem is on the macOS machine: see #159608 (comment). The bug was only seen on this machine for 2 days, whereas the code didn't change.

@StanFromIreland

Copy link
Copy Markdown
Member

This does seem a little odd, but sure it won't hurt I suppose.

@itamaro itamaro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the buildbot worker machine has been recycled and reprovisioned.

I think this PR is still worth merging, regardless of the machine!

@vstinner

Copy link
Copy Markdown
Member Author

@StanFromIreland

This does seem a little odd, but sure it won't hurt I suppose.

@itamaro:

I think this PR is still worth merging, regardless of the machine!

test_faulthandler pass on Linux ASan. It also passed on this macOS ASan buildbot for many months, until only 2 days ago.

@itamaro rebooted the machine and test_faulthandler pass again. So I don't think that this change is needed. I close my PR.

If the situation changes, we can reconsider this change obviously.

@vstinner vstinner closed this Oct 19, 2026
@vstinner
vstinner deleted the test_faulthandler_asan branch October 19, 2026 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting merge needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants