Skip to content

gh-159420: Respect BUILD_DETAILS in test_build_details - #159456

Open
NikitaMikhailov wants to merge 2 commits into
python:mainfrom
NikitaMikhailov:codex/gh-159420-build-details
Open

NikitaMikhailov wants to merge 2 commits into
python:mainfrom
NikitaMikhailov:codex/gh-159420-build-details

Conversation

@NikitaMikhailov

Copy link
Copy Markdown

Fixes gh-159420.

CPythonBuildDetailsTests always looks for build-details.json, so it fails when CPython is configured with --with-build-details-suffix. Use sysconfig's BUILD_DETAILS value to locate the configured filename in both build-tree and installed interpreters.

Validation:

  • Default build: python -m test -v test_build_details passes.
  • Reconfigured and rebuilt with --with-build-details-suffix=contrib; removed the stale unsuffixed build artifact. Before the change, test_build_details reports six FileNotFoundError errors. With the change, it passes.
  • Restored the original default configuration and reran test_build_details successfully.
  • pre-commit checks pass for Lib/test/test_build_details.py.

This changes only the test suite, so no NEWS entry is needed.

AI assistance: Codex helped prepare the change and run validation.

@python-cla-bot

python-cla-bot Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app

bedevere-app Bot commented Oct 15, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app

bedevere-app Bot commented Oct 16, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3.16.0a1: test_build_details is not ready for --with-build-details-suffix configure option

1 participant