Repository navigation
[3.15] gh-157384: Set package context in PyImport_CreateModuleFromInitfunc() (GH-157387) - #159316
Merged
Merged
Conversation
…func() (pythonGH-157387) A single-phase init function that creates its module using only the last component of a dotted name (as pybind11 does for submodules) got a module whose __name__ was the short name. Set the package context while calling the init function, as the dynamic loader does, so the module gets the full name from the spec. (cherry picked from commit 0486228) Co-authored-by: Itamar Oren <itamarost@gmail.com>
miss-islington
requested review from
FFY00,
brettcannon,
ericsnowcurrently,
kumaraditya303,
ncoghlan and
warsaw
as code owners
October 13, 2026 13:35
4 tasks
Documentation build overview
140 files changed ·
|
brettcannon
removed their request for review
October 13, 2026 23:30
meta-codesync Bot
pushed a commit
to facebookincubator/MetaPython
that referenced
this pull request
Oct 15, 2026
…nitfunc() Summary: Backport of the upstream fix (python/cpython#157387, 3.15 backport python/cpython#159316), folded into the `05-native-python-api` patch that carries our 3.14 backport of `PyImport_CreateModuleFromInitfunc`. A single-phase init function that creates its module using only the last component of a dotted name (as pybind11 2.13 does for `PYBIND11_MODULE` extensions inside a package) got a module whose `__name__` was the short name, so `def_submodule` registered submodules under the wrong `sys.modules` keys and `from pkg.ext.sub import x` failed with "`pkg.ext` is not a package". 571 failures in V66 of the py3.14 canary (D82323768) carry this signature. Reviewed By: alexmalyshev Differential Revision: D119701167 fbshipit-source-id: dc50c5ece93752c069548588545eee6526181cad
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A single-phase init function that creates its module using only the
last component of a dotted name (as pybind11 does for submodules) got
a module whose name was the short name. Set the package context
while calling the init function, as the dynamic loader does, so the
module gets the full name from the spec.
(cherry picked from commit 0486228)
Co-authored-by: Itamar Oren itamarost@gmail.com
PyImport_CreateModuleFromInitfunc(): wrong__name__for submodules, non-ASCII names rejected, inittab name clashes #157384