Repository navigation
Conversation
Member
|
LGTM. Some comments, not blockers for merging:
|
nascheme
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
move_unreachable()moves objects with zerogc_refsout of the generation and appends them back when they turn out to be reachable. That leaves the survivors in the order the collector reached them, so every later walk of the generation misses the cache at each step. This flags those objects in place and traverses the reachable ones from a small stack, so the generation keeps its allocation order.Benchmarks
GC time from
gc.get_stats(). Medians of four runs per executable (nine for the AST heap), in baseline/candidate/candidate/baseline order.Collector cycles on the Pylint run. Width is the share before the change, blue frames take fewer cycles after it: