Repository navigation
[3.15] gh-156953: Fix a reference leak in curses window.insnstr() (GH-156954) - #159108
Merged
serhiy-storchaka merged 1 commit intoOct 10, 2026
Merged
Conversation
…() (pythonGH-156954) insnstr() did not release the bytes object it converted its argument to when setting the attributes failed, unlike addstr(), addnstr() and insstr(). (cherry picked from commit 23180c5) Co-authored-by: Vyron Vasileiadis <hi@fedonman.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
insnstr() did not release the bytes object it converted its argument to when setting the attributes failed, unlike addstr(), addnstr() and insstr().
The test is not backported, since it requires
newterm().(cherry picked from commit 23180c5)
Co-authored-by: Vyron Vasileiadis hi@fedonman.com
window.insnstr()leaks itsbytesargument when settingattrfails #156953