Repository navigation
gh-158984: Fix xmlns:prefix attributes set with setAttribute() in minidom - #158989
Open
sricursion wants to merge 1 commit into
Open
sricursion wants to merge 1 commit into
sricursion wants to merge 1 commit into
Conversation
…in minidom Take the prefix of an existing namespace declaration from the attribute name instead of Attr.prefix, which is None for attributes created with the DOM Level 1 API.
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_fixup_namespaces()took the prefix of an existing namespace declaration fromAttr.prefix. That isNonefor attributes created with the DOM Level 1 API (setAttribute(),createAttribute()or a document parsed without namespace processing), even if the name isxmlns:p, so the declaration was recorded for the default namespace. As a resultcreateElementNS(ns, "p:root")followed bysetAttribute("xmlns:p", ns)was written with a duplicatexmlns:p, an element in no namespace got a spuriousxmlns="", and an element in the namespace bound to a prefix this way was written without its ownxmlns. The prefix is now derived from the attribute name. This fixes a problem introduced in gh-44376, which is not released yet, so there is no NEWS entry. It is independent of gh-158208, which concerns a plainxmlnsattribute.