Skip to content

gh-149044: Fix PySlot_END macro for C++ #158866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vstinner wants to merge 4 commits into
base: main
Choose a base branch
from
+3 −1
Open

gh-149044: Fix PySlot_END macro for C++ #158866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
47abf28
gh-149044: Fix PySlot_END macro for C++
vstinner Oct 5, 2026
c3671d7
Add Changelog
vstinner Oct 5, 2026
905c80b
Merge branch 'main' into pyslot_end
vstinner Oct 5, 2026
62b19d8
Initialize PySlot.sl_ptr with _Py_NULL
vstinner Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Include/slots.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ struct PySlot {
#define PySlot_STATIC_DATA(NAME, VALUE) \
{.sl_id=(NAME), .sl_flags=PySlot_STATIC, .sl_ptr=(VALUE)}

#define PySlot_END {0}
#define PySlot_END {0, 0, {0}, {_Py_NULL}}


// Macros without designated initializers (for C++11 and below):
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/C_API/2026-10-05-17-09-35.gh-issue-149044.1HUiag.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix the :c:macro:`PySlot_END` macro for C++: initialize all members to avoid
compiler warnings. Patch by Victor Stinner.
Loading