Skip to content

gh-158868: Make GitHub Action MSan job optional for now - #158865

Closed
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:msan_optional
Closed

vstinner wants to merge 1 commit into
python:mainfrom
vstinner:msan_optional

Conversation

@vstinner

@vstinner vstinner commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

@StanFromIreland

StanFromIreland commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

This is wrong, it'll incorrectly show up as green. It should be made optional in the job that checks all actions pass, that way we're aware if it fails.

We'll have to split it out of the matrix IIRC, I can make such a PR if that's easier?

@vstinner vstinner changed the title Make GitHub Action MSan job optional for now gh-158868: Make GitHub Action MSan job optional for now Oct 5, 2026
@vstinner

vstinner commented Oct 5, 2026

Copy link
Copy Markdown
Member Author

We'll have to split it out of the matrix IIRC, I can make such a PR if that's easier?

I don't see how to do you that. If you know how to do it, please go ahead and create a PR!

I created issue #158868 to track this bug.

@vstinner

vstinner commented Oct 5, 2026

Copy link
Copy Markdown
Member Author

Oh, MSan ran but this time, the test suite passed: https://github.com/python/cpython/actions/runs/37328259158/job/111824581661?pr=158865.

@webknjaz

webknjaz commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

This is wrong, it'll incorrectly show up as green. It should be made optional in the job that checks all actions pass, that way we're aware if it fails.

It is wrong but for a slightly different reason. Kinda. This change is also a no-op — it adds a matrix factor that is not wired anywhere. I told Victor to add a continue-on-error on the specific matrix job but didn't give specific instructions so that's on me.

It would not show up as green, if wired, though. It would show up as a red status in the PR widget and among the jobs in the matrix. But alls-green would see it as green. So it would not be hidden fully.

For these, I'd recommend additionally marking the job name as [xfail] or something.

@StanFromIreland StanFromIreland self-assigned this Oct 5, 2026
@StanFromIreland

Copy link
Copy Markdown
Member

I suggest instead to fix the issue: #158872

@vstinner

vstinner commented Oct 5, 2026

Copy link
Copy Markdown
Member Author

#158872 fixed the MSan issue instead.

@vstinner vstinner closed this Oct 5, 2026
@vstinner
vstinner deleted the msan_optional branch October 5, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants