gh-158863: Drop redundant incref/decref pair in dict_dict_merge() - #158864
Merged
Merged
Conversation
On the override path insertdict() receives its own references to key and value via Py_NewRef(), and nothing in the loop body uses them afterwards, so the outer Py_INCREF/Py_DECREF pair was pure overhead. Keep it only on the non-override path, where _PyDict_Contains_KnownHash() can run arbitrary __eq__ code and *dupkey needs a live reference. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
methane
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For details see the corresponding issue.