[3.14] gh-158102: Add tests for the slice C API (GH-158120) - #158292
Merged
serhiy-storchaka merged 1 commit intoSep 29, 2026
Merged
Conversation
Test PySlice_Check(), PySlice_New(), PySlice_GetIndices(), PySlice_Unpack(), PySlice_AdjustIndices() and PySlice_GetIndicesEx() -- both the macro and the deprecated function. Document the length and step precondition of PySlice_AdjustIndices() (cherry picked from commit 8c056c3) Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> Co-authored-by: Victor Stinner <vstinner@python.org>
serhiy-storchaka
requested review from
a team and
erlend-aasland
as code owners
September 27, 2026 17:34
Documentation build overview
310 files changed ·
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test
PySlice_Check(),PySlice_New(),PySlice_GetIndices(),PySlice_Unpack(),PySlice_AdjustIndices()andPySlice_GetIndicesEx().PySlice_GetIndicesEx()is tested both as a macro and as a deprecated function, including the case when__index__()resizes the sequence whose size is passed as the length: the macro evaluates it afterPySlice_Unpack(), the function before the call.(cherry picked from commit 8c056c3)
The conflicts were only in the registration lists, which have diverged from main:
Modules/Setup.stdlib.in,Modules/_testlimitedcapi.c,Modules/_testlimitedcapi/parts.hand the two PCbuild files.Modules/_testlimitedcapihas noslots.chere, soslice.cis registered betweenset.candsys.c, and the registration calls are inPyInit__testlimitedcapi(), which returnsPyObject *, so the new check returnsNULLinstead of-1.In
Modules/_testlimitedcapi/slice.c,Py_TARGET_ABI3Tdoes not exist in 3.14 -- there is noInclude/pyabi.h-- so the limited C API is simply not tested in a free-threading build, like in the other files ofModules/_testlimitedcapi.