Conversation
…buffer Change so mortal bytes adopted by `bytearray` have their hash cleared. Ensure that bytes which are considerable mutable have a clear hash so it is computed only after they are immutable. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
cmaloney
added
the
needs backport to 3.15
Member
|
Use a bytes object if its hash value was already computed sounds risky to me. Clearing its hash value might just hide bugs. I propose PR gh-158329 to not use a bytes object if its hash value is already computed. Another approach would be to remove the bytearray optimization to reuse a bytes object if its refcount is 1: always create a copy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change so mutable bytes adopted by
bytearrayhave their hash cleared. Ensure that bytes which are considerable mutable have a clear hash so it is computed only after they are immutable.